Skip to content

Commit f9a791e

Browse files
committed
Close #2012: avoid with() to better account for missing tickvals/ticktext
1 parent 49215db commit f9a791e

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Diff for: R/ggplotly.R

+6-3
Original file line numberDiff line numberDiff line change
@@ -1390,10 +1390,13 @@ gdef2trace <- function(gdef, theme, gglayout) {
13901390
rng <- range(gdef$bar$value)
13911391
gdef$bar$value <- scales::rescale(gdef$bar$value, from = rng)
13921392
gdef$key$.value <- scales::rescale(gdef$key$.value, from = rng)
1393+
vals <- lapply(gglayout[c("xaxis", "yaxis")], function(ax) {
1394+
if (identical(ax$tickmode, "auto")) ax$ticktext else ax$tickvals
1395+
})
13931396
list(
1394-
x = with(gglayout$xaxis, if (identical(tickmode, "auto")) ticktext else tickvals)[[1]],
1395-
y = with(gglayout$yaxis, if (identical(tickmode, "auto")) ticktext else tickvals)[[1]],
1396-
# esentially to prevent this getting merged at a later point
1397+
x = vals[[1]][[1]],
1398+
y = vals[[2]][[1]],
1399+
# essentially to prevent this getting merged at a later point
13971400
name = gdef$hash,
13981401
type = "scatter",
13991402
mode = "markers",

0 commit comments

Comments
 (0)