Skip to content

clean up basic geom conversion code #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tdhock opened this issue Apr 14, 2015 · 2 comments
Closed

clean up basic geom conversion code #203

tdhock opened this issue Apr 14, 2015 · 2 comments

Comments

@tdhock
Copy link
Contributor

tdhock commented Apr 14, 2015

My original design for ggplotly included the concept of a "basic" geom which can be directly translated to plotly traces. This simplifies the conversion code since many geoms can be easily converted to a small subset of basic geoms. For example, geom_path is a basic geom, and geom_line and geom_segment are both converted to a path before being converted to a plotly trace. These conversions are implemented in the list of functions toBasic, in trace_generation.R.

I noticed that there are some issues with the current basic geom conversion code:

bar and point are present, but should not be (they are basic geoms).

hline, vline, abline are present, but are not treated as a basic form of geom_path.

@cpsievert
Copy link
Collaborator

@tdhock I think it'd be worthwhile to have a wiki page on this (with maybe a table/diagram to keep track of all the relationships?)

@cpsievert
Copy link
Collaborator

This should be fixed in f1900cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants