Merge pull request #4446 from plotly/mesh3d-intensity-mode

Add intensitymode to allow cell intensity values in mesh3d

Author: archmoj

Diff for: package-lock.json

@@ -80,7 +80,7 @@
     "gl-heatmap2d": "^1.0.5",
     "gl-line3d": "^1.1.11",
     "gl-mat4": "^1.2.0",
-    "gl-mesh3d": "^2.1.3",
+    "gl-mesh3d": "^2.2.0",
     "gl-plot2d": "^1.4.2",
     "gl-plot3d": "^2.3.0",
     "gl-pointcloud2d": "^1.0.2",

Diff for: package.json

@@ -144,8 +144,19 @@ module.exports = extendFlat({
         valType: 'data_array',
         editType: 'calc',
         description: [
-            'Sets the vertex intensity values,',
-            'used for plotting fields on meshes'
+            'Sets the intensity values for vertices or cells',
+            'as defined by `intensitymode`.',
+            'It can be used for plotting fields on meshes.'
+        ].join(' ')
+    },
+    intensitymode: {
+        valType: 'enumerated',
+        values: ['vertex', 'cell'],
+        dflt: 'vertex',
+        editType: 'calc',
+        role: 'info',
+        description: [
+            'Determines the source of `intensity` values.'
         ].join(' ')
     },
 

Diff for: src/traces/mesh3d/attributes.js

@@ -160,8 +160,9 @@ proto.update = function(data) {
     if(data.intensity) {
         var cOpts = extractOpts(data);
         this.color = '#fff';
-        config.vertexIntensity = data.intensity;
-        config.vertexIntensityBounds = [cOpts.min, cOpts.max];
+        var mode = data.intensitymode;
+        config[mode + 'Intensity'] = data.intensity;
+        config[mode + 'IntensityBounds'] = [cOpts.min, cOpts.max];
         config.colormap = parseColorScale(data);
     } else if(data.vertexcolor) {
         this.color = data.vertexcolor[0];

Diff for: src/traces/mesh3d/convert.js

@@ -79,6 +79,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
 
     if('intensity' in traceIn) {
         coerce('intensity');
+        coerce('intensitymode');
         colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'c'});
     } else {
         traceOut.showscale = false;