Skip to content

Commit 104c03f

Browse files
committed
moving gd out of parcoords.js
1 parent e652b16 commit 104c03f

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

Diff for: src/traces/parcoords/parcoords.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ function model(layout, d, i, a) {
140140
return {
141141
key: i,
142142
colCount: d.dimensions.filter(visible).length,
143-
_gdDimensions: d._gdDataItem.dimensions,
144-
_gdDimensionsOriginalOrder: d._gdDataItem.dimensions.slice(),
143+
_gdDimensions: d._gdDimensions,
144+
_gdDimensionsOriginalOrder: d._gdDimensions.slice(),
145145
dimensions: d.dimensions,
146146
tickDistance: c.tickDistance,
147147
unitToColor: unitToColorScale(d.line.colorscale, d.line.cmin, d.line.cmax, d.line.color),
@@ -234,7 +234,7 @@ function styleExtentTexts(selection) {
234234
.style('user-select', 'none');
235235
}
236236

237-
module.exports = function(gd, root, svg, styledData, layout, callbacks) {
237+
module.exports = function(root, svg, styledData, layout, callbacks) {
238238

239239
var domainBrushing = false;
240240
var linePickActive = true;
@@ -529,7 +529,9 @@ module.exports = function(gd, root, svg, styledData, layout, callbacks) {
529529
var i2 = newIdx(d2);
530530
return i1 - i2;
531531
});
532-
gd.emit('plotly_restyle');
532+
if(callbacks && callbacks.axesMoved) {
533+
callbacks.axesMoved();
534+
}
533535
})
534536
);
535537

Diff for: src/traces/parcoords/plot.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module.exports = function plot(gd, cdparcoords) {
1818
var root = fullLayout._paperdiv;
1919
var data = cdparcoords.map(function(d, i) {
2020
var item = Lib.extendDeep(d[0]);
21-
item._gdDataItem = gd.data[i];
21+
item._gdDimensions = gd.data[i].dimensions;
2222
return item;
2323
});
2424

@@ -34,8 +34,11 @@ module.exports = function plot(gd, cdparcoords) {
3434
gd.emit('plotly_unhover', eventData);
3535
};
3636

37+
var axesMoved = function() {
38+
gd.emit('plotly_restyle');
39+
};
40+
3741
parcoords(
38-
gd,
3942
root,
4043
svg,
4144
data,
@@ -46,6 +49,7 @@ module.exports = function plot(gd, cdparcoords) {
4649
{
4750
filterChanged: filterChanged,
4851
hover: hover,
49-
unhover: unhover
52+
unhover: unhover,
53+
axesMoved: axesMoved
5054
});
5155
};

0 commit comments

Comments
 (0)