don't slice uneven arrays in scatter and related traces

instead just record the length as fullTrace._length

Author: alexcjohnson

Diff for: src/plots/cartesian/set_convert.js

@@ -398,15 +398,16 @@ module.exports = function setConvert(ax, fullLayout) {
     // in case the expected data isn't there, make a list of
     // integers based on the opposite data
     ax.makeCalcdata = function(trace, axLetter) {
-        var arrayIn, arrayOut, i;
+        var arrayIn, arrayOut, i, len;
 
         var cal = ax.type === 'date' && trace[axLetter + 'calendar'];
 
         if(axLetter in trace) {
             arrayIn = trace[axLetter];
-            arrayOut = new Array(arrayIn.length);
+            len = trace._length || arrayIn.length;
+            arrayOut = new Array(len);
 
-            for(i = 0; i < arrayIn.length; i++) {
+            for(i = 0; i < len; i++) {
                 arrayOut[i] = ax.d2c(arrayIn[i], 0, cal);
             }
         }
@@ -418,9 +419,10 @@ module.exports = function setConvert(ax, fullLayout) {
 
             // the opposing data, for size if we have x and dx etc
             arrayIn = trace[{x: 'y', y: 'x'}[axLetter]];
-            arrayOut = new Array(arrayIn.length);
+            len = trace._length || arrayIn.length;
+            arrayOut = new Array(len);
 
-            for(i = 0; i < arrayIn.length; i++) arrayOut[i] = v0 + i * dv;
+            for(i = 0; i < len; i++) arrayOut[i] = v0 + i * dv;
         }
         return arrayOut;
     };

Diff for: src/traces/ohlc/transform.js

@@ -213,6 +213,7 @@ exports.calcTransform = function calcTransform(gd, trace, opts) {
     trace.x = x;
     trace.y = y;
     trace.text = textOut;
+    trace._length = x.length;
 };
 
 function convertTickWidth(gd, xa, trace) {

Diff for: src/traces/scatter/calc.js

@@ -24,15 +24,12 @@ function calc(gd, trace) {
     var ya = Axes.getFromId(gd, trace.yaxis || 'y');
     var x = xa.makeCalcdata(trace, 'x');
     var y = ya.makeCalcdata(trace, 'y');
-    var serieslen = Math.min(x.length, y.length);
+    var serieslen = trace._length;
 
     // cancel minimum tick spacings (only applies to bars and boxes)
     xa._minDtick = 0;
     ya._minDtick = 0;
 
-    if(x.length > serieslen) x.splice(serieslen, x.length - serieslen);
-    if(y.length > serieslen) y.splice(serieslen, y.length - serieslen);
-
     // check whether bounds should be tight, padded, extended to zero...
     // most cases both should be padded on both ends, so start with that.
     var xOptions = {padded: true};
@@ -120,9 +117,13 @@ function calcMarkerSize(trace, serieslen) {
         Axes.setConvert(ax);
 
         var s = ax.makeCalcdata(trace.marker, 'size');
-        if(s.length > serieslen) s.splice(serieslen, s.length - serieslen);
 
-        return s.map(markerTrans);
+        var sizeOut = new Array(serieslen);
+        for(var i = 0; i < serieslen; i++) {
+            sizeOut[i] = markerTrans(s[i]);
+        }
+        return sizeOut;
+
     } else {
         return markerTrans(marker.size);
     }

Diff for: src/traces/scatter/xy_defaults.js

@@ -23,13 +23,6 @@ module.exports = function handleXYDefaults(traceIn, traceOut, layout, coerce) {
     if(x) {
         if(y) {
             len = Math.min(x.length, y.length);
-            // TODO: not sure we should do this here... but I think
-            // the way it works in calc is wrong, because it'll delete data
-            // which could be a problem eg in streaming / editing if x and y
-            // come in at different times
-            // so we need to revisit calc before taking this out
-            if(len < x.length) traceOut.x = x.slice(0, len);
-            if(len < y.length) traceOut.y = y.slice(0, len);
         }
         else {
             len = x.length;
@@ -44,5 +37,8 @@ module.exports = function handleXYDefaults(traceIn, traceOut, layout, coerce) {
         coerce('x0');
         coerce('dx');
     }
+
+    traceOut._length = len;
+
     return len;
 };

Diff for: src/traces/scattergl/index.js

@@ -53,7 +53,7 @@ function calc(container, trace) {
     var x = xaxis.type === 'linear' ? trace.x : xaxis.makeCalcdata(trace, 'x');
     var y = yaxis.type === 'linear' ? trace.y : yaxis.makeCalcdata(trace, 'y');
 
-    var count = (x || y).length, i, l, xx, yy;
+    var count = trace._length, i, l, xx, yy;
 
     if(!x) {
         x = Array(count);
@@ -71,28 +71,26 @@ function calc(container, trace) {
     // get log converted positions
     var rawx, rawy;
     if(xaxis.type === 'log') {
-        rawx = Array(x.length);
-        for(i = 0, l = x.length; i < l; i++) {
-            rawx[i] = x[i];
+        rawx = x.slice(0, count);
+        for(i = 0; i < count; i++) {
             x[i] = xaxis.d2l(x[i]);
         }
     }
     else {
         rawx = x;
-        for(i = 0, l = x.length; i < l; i++) {
+        for(i = 0; i < count; i++) {
             x[i] = parseFloat(x[i]);
         }
     }
     if(yaxis.type === 'log') {
-        rawy = Array(y.length);
-        for(i = 0, l = y.length; i < l; i++) {
-            rawy[i] = y[i];
+        rawy = y.slice(0, count);
+        for(i = 0; i < count; i++) {
             y[i] = yaxis.d2l(y[i]);
         }
     }
     else {
         rawy = y;
-        for(i = 0, l = y.length; i < l; i++) {
+        for(i = 0; i < count; i++) {
             y[i] = parseFloat(y[i]);
         }
     }

Diff for: src/transforms/filter.js

@@ -219,6 +219,7 @@ exports.calcTransform = function(gd, trace, opts) {
     }
 
     opts._indexToPoints = indexToPoints;
+    trace._length = index;
 };
 
 function getFilterFunc(opts, d2c, targetCalendar) {