Skip to content

Commit 506ed1c

Browse files
authored
Merge pull request #6487 from plotly/avoid-d3-export
Avoid attaching internal d3 object to the window
2 parents 4a91a74 + 39f817b commit 506ed1c

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

Diff for: package-lock.json

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
]
7171
},
7272
"dependencies": {
73-
"@plotly/d3": "3.8.0",
73+
"@plotly/d3": "3.8.1",
7474
"@plotly/d3-sankey": "0.7.2",
7575
"@plotly/d3-sankey-circular": "0.33.1",
7676
"@turf/area": "^6.4.0",

Diff for: test/jasmine/bundle_tests/minified_bundle_test.js

+4
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,8 @@ describe('Test plotly.min.js', function() {
2525
Plotly.newPlot(gd, mockSpec[1]).catch(fail).then(done);
2626
}, LONG_TIMEOUT_INTERVAL);
2727
});
28+
29+
it('should not expose d3', function() {
30+
expect(window.d3).not.toBeDefined();
31+
});
2832
});

0 commit comments

Comments
 (0)