Skip to content

Commit 679ed9c

Browse files
committed
remove obsolete comments, esp. about 3d pies
1 parent 9bfbabf commit 679ed9c

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

Diff for: src/traces/pie/defaults.js

+2-14
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,10 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
3434
if(lineWidth) coerce('marker.line.color');
3535

3636
var colors = coerce('marker.colors');
37-
if(!Array.isArray(colors)) traceOut.marker.colors = []; // later this will get padded with default colors
37+
if(!Array.isArray(colors)) traceOut.marker.colors = [];
3838

3939
coerce('scalegroup');
40-
// TODO: tilt, depth, and hole all need to be coerced to the same values within a scaleegroup
41-
// (ideally actually, depth would get set the same *after* scaling, ie the same absolute depth)
42-
// and if colors aren't specified we should match these up - potentially even if separate pies
43-
// are NOT in the same sharegroup
44-
40+
// TODO: hole needs to be coerced to the same value within a scaleegroup
4541

4642
var textData = coerce('text');
4743
var textInfo = coerce('textinfo', Array.isArray(textData) ? 'text+percent' : 'percent');
@@ -63,14 +59,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
6359
coerce('domain.x');
6460
coerce('domain.y');
6561

66-
// 3D attributes commented out until I finish them in a later PR
67-
// var tilt = coerce('tilt');
68-
// if(tilt) {
69-
// coerce('tiltaxis');
70-
// coerce('depth');
71-
// coerce('shading');
72-
// }
73-
7462
coerce('hole');
7563

7664
coerce('sort');

0 commit comments

Comments
 (0)