Skip to content

Commit 7a3b075

Browse files
committed
cleaner handling of bin defaults
1 parent 5aaa0df commit 7a3b075

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/traces/histogram/bin_defaults.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@ module.exports = function handleBinDefaults(traceIn, traceOut, coerce, binDirect
2323
coerce(binDirection + 'bins.start');
2424
coerce(binDirection + 'bins.end');
2525
coerce(binDirection + 'bins.size');
26-
coerce('autobin' + binDirection);
27-
coerce('nbins' + binDirection);
26+
27+
var autobin = coerce('autobin' + binDirection);
28+
if(autobin !== false) coerce('nbins' + binDirection);
2829
});
2930

3031
return traceOut;

src/traces/histogram/clean_bins.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ module.exports = function cleanBins(trace, ax, binDirection) {
6565
var autoBinAttr = 'autobin' + binDirection;
6666

6767
if(typeof trace[autoBinAttr] !== 'boolean') {
68-
trace[autoBinAttr] = !(
68+
trace[autoBinAttr] = trace._input[autoBinAttr] = !(
6969
(bins.start || bins.start === 0) &&
7070
(bins.end || bins.end === 0)
7171
);

0 commit comments

Comments
 (0)