Skip to content

Commit 9c06996

Browse files
authored
Merge pull request #5878 from 3dcl/promiseError-undefined
removed invalid .then call using lib.promiseError which does not exis…
2 parents e27ca3c + 1fa7b34 commit 9c06996

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Diff for: draftlogs/5878_fix.md

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- Fix invalid call to `lib.promiseError` in lib.syncOrAsync [[#5878](https://github.com/plotly/plotly.js/pull/5878)],
2+
with thanks to @jklimke for the contribution!

Diff for: src/lib/index.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -455,8 +455,7 @@ lib.syncOrAsync = function(sequence, arg, finalStep) {
455455
ret = fni(arg);
456456

457457
if(ret && ret.then) {
458-
return ret.then(continueAsync)
459-
.then(undefined, lib.promiseError);
458+
return ret.then(continueAsync);
460459
}
461460
}
462461

0 commit comments

Comments
 (0)