Skip to content

Commit ab5e16a

Browse files
authored
Merge pull request #6649 from plotly/skip-stamen-watercolor-for-now
do not run stamen-watercolor tests on CI for now
2 parents ac2ce66 + daa5b7b commit ab5e16a

File tree

5 files changed

+13
-5
lines changed

5 files changed

+13
-5
lines changed

Diff for: test/image/compare_pixels_test.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,15 @@ argv._.forEach(function(pattern) {
5656
}
5757
});
5858

59-
// skip for now | TODO: figure out why needed this in https://github.com/plotly/plotly.js/pull/6610
60-
allMockList = allMockList.filter(function(a) { return a !== 'mapbox_custom-style';});
59+
allMockList = allMockList.filter(function(a) {
60+
return (
61+
// used to pass before 2023 Jun 20
62+
a !== 'mapbox_stamen-style' &&
63+
64+
// skip for now | TODO: figure out why needed this in https://github.com/plotly/plotly.js/pull/6610
65+
a !== 'mapbox_custom-style'
66+
);
67+
});
6168

6269
if(mathjax3) {
6370
allMockList = [

Diff for: test/image/export_test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var DEFAULT_LIST = [
2626
'image_astronaut_source',
2727
'gl2d_no-clustering2',
2828
'gl3d_surface-heatmap-treemap_transparent-colorscale',
29-
'mapbox_stamen-style',
29+
'mapbox_density-multiple_legend',
3030
'smith_modes',
3131
'zsmooth_methods',
3232
'fonts',

Diff for: test/image/make_baseline.py

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
blacklist = [
7979
'mapbox_density0-legend',
8080
'mapbox_osm-style',
81+
'mapbox_stamen-style', # used to pass before 2023 Jun 20
8182
'mapbox_custom-style' # Figure out why needed this in https://github.com/plotly/plotly.js/pull/6610
8283
]
8384
allNames = [a for a in allNames if a not in blacklist]

Diff for: test/image/make_exports.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
'image_astronaut_source',
2828
'gl2d_no-clustering2',
2929
'gl3d_surface-heatmap-treemap_transparent-colorscale',
30-
'mapbox_stamen-style',
30+
'mapbox_density-multiple_legend',
3131
'smith_modes',
3232
'zsmooth_methods',
3333
'fonts',

Diff for: test/jasmine/tests/mapbox_test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1513,7 +1513,7 @@ describe('mapbox plots', function() {
15131513
});
15141514
});
15151515

1516-
it('@gl should be displayed for style "stamen-watercolor"', function(done) {
1516+
it('@noCI @gl should be displayed for style "stamen-watercolor"', function(done) {
15171517
Plotly.newPlot(gd, [{type: 'scattermapbox'}], {mapbox: {style: 'stamen-watercolor'}})
15181518
.then(function() {
15191519
var s = d3SelectAll('.mapboxgl-ctrl-attrib');

0 commit comments

Comments
 (0)