Skip to content

Commit be47021

Browse files
committed
hasHeatmapgl > hasGL2D
1 parent f8f08cf commit be47021

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Diff for: src/components/modebar/manage.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ function getButtonGroups(gd) {
8989
var hasGeo = fullLayout._has('geo');
9090
var hasPie = fullLayout._has('pie');
9191
var hasFunnelarea = fullLayout._has('funnelarea');
92-
var hasHeatmapgl = fullLayout._has('gl2d');
92+
var hasGL2D = fullLayout._has('gl2d');
9393
var hasTernary = fullLayout._has('ternary');
9494
var hasMapbox = fullLayout._has('mapbox');
9595
var hasPolar = fullLayout._has('polar');
@@ -124,7 +124,7 @@ function getButtonGroups(gd) {
124124
var resetGroup = [];
125125
var dragModeGroup = [];
126126

127-
if((hasCartesian || hasHeatmapgl || hasPie || hasFunnelarea || hasTernary) + hasGeo + hasGL3D + hasMapbox + hasPolar > 1) {
127+
if((hasCartesian || hasGL2D || hasPie || hasFunnelarea || hasTernary) + hasGeo + hasGL3D + hasMapbox + hasPolar > 1) {
128128
// graphs with more than one plot types get 'union buttons'
129129
// which reset the view or toggle hover labels across all subplots.
130130
hoverGroup = ['toggleHover'];
@@ -140,7 +140,7 @@ function getButtonGroups(gd) {
140140
zoomGroup = ['zoomInMapbox', 'zoomOutMapbox'];
141141
hoverGroup = ['toggleHover'];
142142
resetGroup = ['resetViewMapbox'];
143-
} else if(hasHeatmapgl) {
143+
} else if(hasGL2D) {
144144
hoverGroup = ['hoverClosestGl2d'];
145145
} else if(hasPie) {
146146
hoverGroup = ['hoverClosestPie'];
@@ -161,14 +161,14 @@ function getButtonGroups(gd) {
161161
hoverGroup = [];
162162
}
163163

164-
if((hasCartesian || hasHeatmapgl) && !allAxesFixed) {
164+
if((hasCartesian || hasGL2D) && !allAxesFixed) {
165165
zoomGroup = ['zoomIn2d', 'zoomOut2d', 'autoScale2d'];
166166
if(resetGroup[0] !== 'resetViews') resetGroup = ['resetScale2d'];
167167
}
168168

169169
if(hasGL3D) {
170170
dragModeGroup = ['zoom3d', 'pan3d', 'orbitRotation', 'tableRotation'];
171-
} else if(((hasCartesian || hasHeatmapgl) && !allAxesFixed) || hasTernary) {
171+
} else if(((hasCartesian || hasGL2D) && !allAxesFixed) || hasTernary) {
172172
dragModeGroup = ['zoom2d', 'pan2d'];
173173
} else if(hasMapbox || hasGeo) {
174174
dragModeGroup = ['pan2d'];

Diff for: src/plots/plots.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -468,11 +468,11 @@ plots.supplyDefaults = function(gd, opts) {
468468
plots.cleanPlot(newFullData, newFullLayout, oldFullData, oldFullLayout);
469469

470470
var hadHeatmapgl = !!(oldFullLayout._has && oldFullLayout._has('gl2d'));
471-
var hasHeatmapgl = !!(newFullLayout._has && newFullLayout._has('gl2d'));
471+
var hasGL2D = !!(newFullLayout._has && newFullLayout._has('gl2d'));
472472
var hadCartesian = !!(oldFullLayout._has && oldFullLayout._has('cartesian'));
473473
var hasCartesian = !!(newFullLayout._has && newFullLayout._has('cartesian'));
474474
var hadBgLayer = hadCartesian || hadHeatmapgl;
475-
var hasBgLayer = hasCartesian || hasHeatmapgl;
475+
var hasBgLayer = hasCartesian || hasGL2D;
476476
if(hadBgLayer && !hasBgLayer) {
477477
// remove bgLayer
478478
oldFullLayout._bgLayer.remove();

0 commit comments

Comments
 (0)