Skip to content

Commit f547692

Browse files
committed
add a few TODO comments related to polar.hole
1 parent ea7fd2c commit f547692

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

Diff for: src/plots/polar/constants.js

+3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ module.exports = {
2424
'frontplot',
2525
'angular-axis',
2626
'radial-axis',
27+
// TODO hmm, putting angular-line above radial-axis
28+
// can sometimes hide radial ticks and label
29+
// this happens especially for the 'inner' angular axis
2730
'angular-line',
2831
'radial-line'
2932
],

Diff for: src/plots/polar/polar.js

+5
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,9 @@ proto.updateAngularAxis = function(fullLayout, polarLayout) {
597597
}
598598
_this.vangles = vangles;
599599

600+
// TODO maybe two arcs is better here?
601+
// maybe split style attributes between inner and outer angular axes?
602+
600603
updateElement(layers['angular-line'].select('path'), angularLayout.showline, {
601604
d: _this.pathSubplot(),
602605
transform: strTranslate(cx, cy)
@@ -937,6 +940,8 @@ proto.updateRadialDrag = function(fullLayout) {
937940
var tx = cx + (radius + bl2) * Math.cos(angle0);
938941
var ty = cy - (radius + bl2) * Math.sin(angle0);
939942

943+
// TODO add 'inner' drag box when innerRadius > 0 !!
944+
940945
d3.select(radialDrag)
941946
.attr('transform', strTranslate(tx, ty));
942947

0 commit comments

Comments
 (0)