Skip to content

Regression bug: LASSOing has become significantly slower between 1.31 to 1.32 #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daattali opened this issue Mar 8, 2018 · 4 comments · Fixed by #2583
Closed

Regression bug: LASSOing has become significantly slower between 1.31 to 1.32 #2459

daattali opened this issue Mar 8, 2018 · 4 comments · Fixed by #2583
Labels
bug something broken

Comments

@daattali
Copy link

daattali commented Mar 8, 2018

Codepen with sample code: https://codepen.io/anon/pen/NYWNde

Having 10,000 points in a scatterplot, if I wanted to LASSO select some points with plotly1.31 it was fairly smooth. If I try the same thing with plotly1.32+ it becomes agonizingly slow.

yearlyadepthornshark-max-14mb

On Windows 7 Pro, using Chrome v64

Originally reported to @cpsievert at plotly/plotly.R#1216

@etpinard
Copy link
Contributor

etpinard commented Mar 8, 2018

Thanks for the report! To be more precise, the issue is with SVG scatter (i.e. scattergl is fine).

@etpinard etpinard added bug something broken type: performance labels Mar 8, 2018
@etpinard
Copy link
Contributor

Arrg. I suspect #2135 is the culprit here. We'll have to speed up _module.style. Thanks again for the report!

@etpinard
Copy link
Contributor

One more reason to start stashing points selections (cc #2548)

@daattali
Copy link
Author

As the issue opener, I just want to confirm this is indeed fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants