Skip to content

Duplicate Key in _$colorScale_104? #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ToucanBran opened this issue Apr 5, 2018 · 5 comments
Closed

Duplicate Key in _$colorScale_104? #2528

ToucanBran opened this issue Apr 5, 2018 · 5 comments

Comments

@ToucanBran
Copy link

Not sure if this is a huge deal but I was trying to compile plotly.js to ES2015 using google's closure compiler which was throwing an error of duplicate key "cool" on line 121905. I looked at all the other keys for the _$colorScale_104 dictionary and noticed that there was indeed another key called "cool" on line 121855. I was able to get it to compile by changing one of the key names but that seems kind of bad.

This is plotly v1.35.2.

@etpinard
Copy link
Contributor

etpinard commented Apr 5, 2018

Looks like you're trying to compile one of our already minified bundles (those $_??? keys come from browser-pack-flat).

It's probably best to compile un-minified code e.g. dist/plotly.js instead of dist/plotly.min.js.

@ToucanBran
Copy link
Author

ToucanBran commented Apr 5, 2018

dist/plotly.js seems to show the same code (i.e. the _$colorScale_104 variable) and duplicate key, perhaps I'm missing something?

@etpinard
Copy link
Contributor

etpinard commented Apr 5, 2018

Oh right. We browser-pack-flat those too. My bad.

@etpinard
Copy link
Contributor

@ToucanBran we just released new dist/ bundles. Can you confirm whether this problem persists?

@etpinard
Copy link
Contributor

We dropped browser-pack-flat in #2572

So this issue should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants