Skip to content

Uncaught (in promise) TypeError: doneFnCompleted is not a function #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lavor opened this issue Apr 10, 2019 · 1 comment · Fixed by #3755
Closed

Uncaught (in promise) TypeError: doneFnCompleted is not a function #3754

lavor opened this issue Apr 10, 2019 · 1 comment · Fixed by #3755
Assignees
@etpinard
Labels
bug something broken

Comments

@lavor
Copy link

lavor commented Apr 10, 2019

Hi, the release version 1.47.0 adds call of method doneFnCompleted:
627fd74#diff-8c5d8f688f2bb41a18d35397e5f58864R290

This method is initialized only in sankey's base_plot.js:
627fd74#diff-2d7d5b2875d00ef73d8c35008560ea17R90

Otherwise doneFnCompleted it is not initialized and a browser reports an error whenever the Box select or the Lasso select from toolbar is used:
Uncaught (in promise) TypeError: doneFnCompleted is not a function
@etpinard
Copy link
Contributor

Thanks very much for the report 👍

@etpinard etpinard added the bug something broken label Apr 10, 2019
@etpinard etpinard self-assigned this Apr 10, 2019
@etpinard etpinard mentioned this issue Apr 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't try to call doneFnCompleted when it isn't set plotly/plotly.js
2 participants
@etpinard @lavor