Skip to content

Waterfall textinfo #3777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolaskruchten opened this issue Apr 16, 2019 · 6 comments
Closed

Waterfall textinfo #3777

nicolaskruchten opened this issue Apr 16, 2019 · 6 comments
Assignees
Labels
feature something new

Comments

@nicolaskruchten
Copy link
Contributor

I think we'll need some textinfo for waterfalls, so as to be able to show the total value as text.

@archmoj archmoj self-assigned this Apr 16, 2019
@archmoj archmoj added the feature something new label Apr 16, 2019
@archmoj
Copy link
Contributor

archmoj commented Apr 16, 2019

Here is a prototype by reusing some of the logic in pie.

@nicolaskruchten
Copy link
Contributor Author

Pretty cool! What are the available flags? Can I show value+initial or something? If so, what does that end up looking like?

@archmoj
Copy link
Contributor

archmoj commented Apr 17, 2019

@nicolaskruchten the early prototype used to apply the options identical to pie.
However as @etpinard pointed out #3782 (comment) we may have different set of flags for waterfalls.
What about this list?
[label, text, sum value, diff value, diff percent, sum percent]

@nicolaskruchten
Copy link
Contributor Author

what would those look like? one per line?

@nicolaskruchten
Copy link
Contributor Author

I would do:

  • value (the delta value!), initial, final, and text (which is whatever was provided in the text attr)
  • I would display these one-per-line

@archmoj
Copy link
Contributor

archmoj commented Apr 17, 2019

I like delta over value. Value is a bit confusing considering base, etc.
Here is an updated codepen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

No branches or pull requests

2 participants