Skip to content

Individual negative values discarded in pie chart #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justin-sleep opened this issue Feb 8, 2021 · 1 comment · Fixed by #6051
Closed

Individual negative values discarded in pie chart #5481

justin-sleep opened this issue Feb 8, 2021 · 1 comment · Fixed by #6051
Labels
bug something broken
Milestone

Comments

@justin-sleep
Copy link
Contributor

It looks like negative values are dropped when constructing pie charts, probably to prevent negative sums (example). I think this is the line responsible for this behavior, and that it could be fixed by checking for negative values in the sums rather than checking the individual points.

@alexcjohnson
Copy link
Collaborator

Good call @justin-sleep - the negative exclusion predates automatic aggregation, and was never updated to be done after the sums are complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
3 participants