-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
pattern bgcolor & fgcolor as well as overlay fillmode #5728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like the behavior. Maybe change the value from |
I guess I meant it as "the pattern takes the place of the fill"... what's the case for "mask" ? |
"fill" sounds to me like "the pattern fills the bar", which isn't any more true for this mode than for overlay mode. By "mask" I meant "the pattern masks the bar fill" which feels more directly opposed to "the pattern overlays the bar fill" - I grant though that this is fairly technical / esoteric usage of the word "mask" so if there's a better word I'm all ears :) |
How about |
|
Right now patterns basically replace fills, and I want to introduce a second mode where they overlay them instead:
marker.pattern.fillmode= enum(default=replace, overlay)
marker.pattern.fgcolor
replace
fillmode is the current behaviour:marker.pattern.bgcolor
is transparentmarker.pattern.fgcolor
=marker.color
overlay
fillmode will be:marker.pattern.bgcolor
=marker.color
marker.pattern.fgcolor
will be set to to contrast thebgcolor
using the same algo we use to contrast text on barsThe text was updated successfully, but these errors were encountered: