Skip to content

es-pe locale has incorrect number format specification #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andresrcs opened this issue Jan 29, 2023 · 2 comments
Closed

es-pe locale has incorrect number format specification #6450

andresrcs opened this issue Jan 29, 2023 · 2 comments

Comments

@andresrcs
Copy link
Contributor

andresrcs commented Jan 29, 2023

The "es-pe" locale has incorrect number format specification, it should use these values:

decimal: "."
thousands: ","
grouping: [3]
currency: ["S/", ""]

But it uses the Spanish (es) number format with a dollar symbol ($) for currency.

If I use this tickformat in Plotly R

yaxis = list(title = 'Monto (S/)',
             zerolinecolor = '#ffff',
             zerolinewidth = 2,
             gridcolor = 'ffff',
             tickformat = '$,.0f',
             hoverformat = '$,.0f'),

I get this which is incorrect

image

@alexcjohnson
Copy link
Collaborator

Thanks @andresrcs - would you be able to make a PR to update https://github.com/plotly/plotly.js/blob/master/lib/locales/es-pe.js with the correct entries, and ask one other Peruvian to review and approve?

@andresrcs
Copy link
Contributor Author

Thanks, I have made the PR #6451
I'll look into getting another Peruvian to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants