Skip to content

Replace country-regex Part 2 #7026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G-2-Z opened this issue Jun 14, 2024 · 5 comments
Open

Replace country-regex Part 2 #7026

G-2-Z opened this issue Jun 14, 2024 · 5 comments
Assignees
Labels
bug something broken infrastructure build process etc. P2 considered for next cycle

Comments

@G-2-Z
Copy link

G-2-Z commented Jun 14, 2024

Plotly.js still contains country-regex as a dependency. I'll just cite @keithrob from his original PR:

"The NPM package that is currently used by plotly, country-regex, is a very good package for taking common country names and correlating them to their ISO3 codes. However, it used a GPLed regex library from the R package countrycode. It is questionable whether country-regex can be a MIT license when it is a direct descendent of R version."

I'm not sure about the MIT license, but every project that uses plotly.js might be a derived work of this original GPL licensed project and therefore subject to its copyleft restrictions. This might light up in your deep inspecting license compliance tool and might make your lawyer sweaty.

see #3944
see keithrob#1

@gvwilson
Copy link
Contributor

hi @archmoj - can you please let me know if you want to factor this into ongoing map changes or push to the next cycle? I'm happy either way.

@gvwilson gvwilson self-assigned this Jul 20, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added bug something broken P1 needed for current cycle infrastructure build process etc. P2 considered for next cycle and removed P1 needed for current cycle labels Aug 9, 2024
@dimitrov570
Copy link

Hi,

What is the status of this issue? Could you please provide an update on when this is planned to be resolved? It is currently being detected by license compliance inspecting tools.

Thank you!

@gvwilson
Copy link
Contributor

gvwilson commented Oct 8, 2024

It is currently in our backlog but won't be in the major release later this month unless someone from the community does a PR in the next few days. We can try to get it into the next minor release, but again, a community PR would greatly increase the chances of that happening. Thanks - @gvwilson

@dimitrov570
Copy link

It is currently in our backlog but won't be in the major release later this month unless someone from the community does a PR in the next few days. We can try to get it into the next minor release, but again, a community PR would greatly increase the chances of that happening. Thanks - @gvwilson

I would like to contribute. Is using i18n-iso-countries satisfactory solution for your requirements (as it's done here keithrob#1)?

@gvwilson
Copy link
Contributor

Thanks @dimitrov570 - yes, we'd be very grateful for a PR, and the package you mention looks like a good starting point - thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken infrastructure build process etc. P2 considered for next cycle
Projects
None yet
Development

No branches or pull requests

4 participants