From e37a0f8fbc0e695ac2737f1b42a064e1af6dac6a Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 9 May 2019 12:40:32 -0400 Subject: [PATCH] display true boolean text on bars --- src/traces/bar/helpers.js | 2 +- test/jasmine/tests/bar_test.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/traces/bar/helpers.js b/src/traces/bar/helpers.js index a17a0552f15..afe5a2d6ff0 100644 --- a/src/traces/bar/helpers.js +++ b/src/traces/bar/helpers.js @@ -14,7 +14,7 @@ var tinycolor = require('tinycolor2'); exports.coerceString = function(attributeDefinition, value, defaultValue) { if(typeof value === 'string') { if(value || !attributeDefinition.noBlank) return value; - } else if(typeof value === 'number') { + } else if(typeof value === 'number' || value === true) { if(!attributeDefinition.strict) return String(value); } diff --git a/test/jasmine/tests/bar_test.js b/test/jasmine/tests/bar_test.js index 51deb89951f..da1b7faeb9d 100644 --- a/test/jasmine/tests/bar_test.js +++ b/test/jasmine/tests/bar_test.js @@ -1849,6 +1849,10 @@ describe('A bar plot', function() { }) .then(function() { _assertNumberOfBarTextNodes(3); + return Plotly.restyle(gd, 'text', [[null, true, '']]); + }) + .then(function() { + _assertNumberOfBarTextNodes(1); }) .catch(failTest) .then(done);