Skip to content

Commit 1860acc

Browse files
committed
Specify utf-8 in script tag
1 parent 9050c4b commit 1860acc

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

Diff for: packages/python/plotly/plotly/io/_html.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -272,23 +272,23 @@ def to_html(
272272
elif include_plotlyjs == "cdn":
273273
load_plotlyjs = """\
274274
{win_config}
275-
<script src="{cdn_url}"></script>\
275+
<script charset="utf-8" src="{cdn_url}"></script>\
276276
""".format(
277277
win_config=_window_plotly_config, cdn_url=plotly_cdn_url()
278278
)
279279

280280
elif include_plotlyjs == "directory":
281281
load_plotlyjs = """\
282282
{win_config}
283-
<script src="plotly.min.js"></script>\
283+
<script charset="utf-8" src="plotly.min.js"></script>\
284284
""".format(
285285
win_config=_window_plotly_config
286286
)
287287

288288
elif isinstance(include_plotlyjs, str) and include_plotlyjs.endswith(".js"):
289289
load_plotlyjs = """\
290290
{win_config}
291-
<script src="{url}"></script>\
291+
<script charset="utf-8" src="{url}"></script>\
292292
""".format(
293293
win_config=_window_plotly_config, url=include_plotlyjs_orig
294294
)

Diff for: packages/python/plotly/plotly/tests/test_core/test_offline/test_offline.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,11 @@
4141
<script type="text/javascript">\
4242
window.PlotlyConfig = {MathJaxConfig: 'local'};</script>"""
4343

44-
cdn_script = '<script src="{cdn_url}"></script>'.format(cdn_url=plotly_cdn_url())
44+
cdn_script = '<script charset="utf-8" src="{cdn_url}"></script>'.format(
45+
cdn_url=plotly_cdn_url()
46+
)
4547

46-
directory_script = '<script src="plotly.min.js"></script>'
48+
directory_script = '<script charset="utf-8" src="plotly.min.js"></script>'
4749

4850

4951
mathjax_cdn = "https://cdnjs.cloudflare.com" "/ajax/libs/mathjax/2.7.5/MathJax.js"

Diff for: packages/python/plotly/plotly/tests/test_io/test_renderers.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,9 @@ def test_repr_html(renderer):
311311
template = (
312312
'<div> <script type="text/javascript">'
313313
"window.PlotlyConfig = {MathJaxConfig: 'local'};</script>\n "
314-
'<script src="' + plotly_cdn_url() + '"></script> '
314+
'<script charset="utf-8" src="'
315+
+ plotly_cdn_url()
316+
+ '"></script> '
315317
'<div id="cd462b94-79ce-42a2-887f-2650a761a144" class="plotly-graph-div" '
316318
'style="height:100%; width:100%;"></div> <script type="text/javascript">'
317319
" window.PLOTLYENV=window.PLOTLYENV || {};"

0 commit comments

Comments
 (0)