Merge pull request #4305 from bwest2397/workaround-px-express-line-not-accepting-spline-on-large-dataframes

alexcjohnson · web-flow · commit a8a2533a8ce0 · 2023-11-11T07:19:02.000-05:00
px.line: don't use webgl if line_shape="spline" is given
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 - Fix issue with creating dendrogram in subplots [[#4411](https://github.com/plotly/plotly.py/pull/4411)],
+- Fix issue with px.line not accepting "spline" line shape [[#2812](https://github.com/plotly/plotly.py/issues/2812)],
 
 ## [5.18.0] - 2023-10-25
 
diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py
@@ -812,6 +812,7 @@ def make_trace_spec(args, constructor, attrs, trace_patch):
             or (
                 args["render_mode"] == "auto"
                 and len(args["data_frame"]) > 1000
+                and args.get("line_shape") != "spline"
                 and args["animation_frame"] is None
             )
         ):

Original file line number	Diff line number	Diff line change
`@@ -812,6 +812,7 @@ def make_trace_spec(args, constructor, attrs, trace_patch):`
`812`	`812`	`or (`
`813`	`813`	`args["render_mode"] == "auto"`
`814`	`814`	`and len(args["data_frame"]) > 1000`
	`815`	`+ and args.get("line_shape") != "spline"`
`815`	`816`	`and args["animation_frame"] is None`
`816`	`817`	`)`
`817`	`818`	`):`