erasing/dealing with some TODOs

Author: Kully

makefile

@@ -28,9 +28,8 @@ update_default_schema :
 	@echo "Auto-generating graph objects based on updated default-schema."
 	@echo "Warning: Make sure you are running 'make update_default_schema' with Python 3.6.
 		   The code generating scripts requires 3.6 to run."
-	python codegen/__init__.py
-	# TODO: fix code breaking with update_default_schema
-	# python setup.py codegen
+	python setup.py codegen
+
 
 install : sync_subs
 	@echo ""

plotly/basedatatypes.py

@@ -3570,16 +3570,6 @@ def __setattr__(self, prop, value):
             # Set as subplotid property
             self._set_subplotid_prop(prop, value)
 
-    # TODO - remove old __dir__ magic method below?
-    # def __dir__(self):
-    #     """
-    #     Custom __dir__ that handles dynamic subplot properties
-    #     """
-    #     # Include any active subplot values
-    #     return list(super(BaseLayoutHierarchyType, self).__dir__()) + sorted(self._subplotid_props)
-    #     #return list(dir(super(BaseLayoutHierarchyType, self))) + sorted(self._subplotid_props)
-
-
     def __dir__(self):
         """
         Custom __dir__ that handles dynamic subplot properties

plotly/plotly/plotly.py

@@ -654,16 +654,14 @@ def write(self, trace, layout=None,
         validate = False
 
         # Convert trace objects to dictionaries
-        
         if isinstance(trace, BaseTraceType):
-           trace = trace.to_plotly_json()
+            trace = trace.to_plotly_json()
 
         stream_object = dict()
         stream_object.update(trace)
         if 'type' not in stream_object:
             # tests if Scatter contains invalid kwargs
-            # TODO: replace Scatter with something else
-            #dummy_obj = copy.deepcopy(Scatter(**stream_object))
+            dummy_obj = copy.deepcopy(Scatter(**stream_object))
             stream_object = Scatter(**stream_object)
             stream_object['type'] = 'scatter'
 

plotly/tests/test_optional/test_matplotlylib/data/lines.py

@@ -85,7 +85,7 @@
                 symbol='circle',
                 line=Line(
                     color='#FF0000',
-                    width=1.0 # TODO: change later?
+                    width=1.0
                 ),
                 size=10,
                 color='#FF0000',

plotly/tests/test_optional/test_utils/test_utils.py

@@ -148,7 +148,6 @@ def test_encode_as_date(self):
         self.assertEqual(res, '2013-10-01')
 
         # should also work with a date time without a utc offset!
-        # TODO: is this OK? We could raise errors after checking isinstance...
         res = utils.PlotlyJSONEncoder.encode_as_date(
             datetime.datetime(2013, 10, 1, microsecond=10)
         )
@@ -159,7 +158,7 @@ def test_encode_as_decimal(self):
         # should work with decimal values
         res = utils.PlotlyJSONEncoder.encode_as_decimal(decimal.Decimal(1.023452))
 
-        self.assertAlmostEqual(res, 1.023452) # Checks upto 7 decimal places
+        self.assertAlmostEqual(res, 1.023452)  # Checks upto 7 decimal places
         self.assertIsInstance(res, float)
 
 ## JSON encoding