Skip to content

Commit e54147a

Browse files
committed
Remove default width/height for static image renderers
Now the image size precedence is: - width/height provided to fig.show() - width/height specified in figure - width/height specified in the kaleido scope
1 parent 70877b4 commit e54147a

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

Diff for: packages/python/plotly/plotly/io/_renderers.py

+4-5
Original file line numberDiff line numberDiff line change
@@ -428,13 +428,12 @@ def show(fig, renderer=None, validate=True, **kwargs):
428428
renderers["json"] = JsonRenderer()
429429

430430
# Static Image
431-
img_kwargs = dict(height=450, width=700)
432-
renderers["png"] = PngRenderer(**img_kwargs)
433-
jpeg_renderer = JpegRenderer(**img_kwargs)
431+
renderers["png"] = PngRenderer()
432+
jpeg_renderer = JpegRenderer()
434433
renderers["jpeg"] = jpeg_renderer
435434
renderers["jpg"] = jpeg_renderer
436-
renderers["svg"] = SvgRenderer(**img_kwargs)
437-
renderers["pdf"] = PdfRenderer(**img_kwargs)
435+
renderers["svg"] = SvgRenderer()
436+
renderers["pdf"] = PdfRenderer()
438437

439438
# External
440439
renderers["browser"] = BrowserRenderer(config=config)

Diff for: packages/python/plotly/plotly/tests/test_optional/test_kaleido/test_kaleido.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,5 @@ def test_image_renderer():
9999

100100
renderer = pio.renderers["svg"]
101101
scope.transform.assert_called_with(
102-
fig,
103-
format="svg",
104-
width=renderer.width,
105-
height=renderer.height,
106-
scale=renderer.scale,
102+
fig, format="svg", width=None, height=None, scale=renderer.scale,
107103
)

0 commit comments

Comments
 (0)