Skip to content

Codegen seems broken! #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
archmoj opened this issue Nov 13, 2024 · 4 comments
Closed

Codegen seems broken! #4870

archmoj opened this issue Nov 13, 2024 · 4 comments

Comments

@archmoj
Copy link
Contributor

archmoj commented Nov 13, 2024

After PRs merged today it appears the codegen is not producing the correct outputs.

In the morning I was able to generate correct plotly.py code after 5497d17

But now I can not locate this file: packages/javascript/jupyterlab-plotly/package.json i.e. to control the version of plotly.js.

@marthacryan
Copy link
Collaborator

marthacryan commented Nov 13, 2024

The new source of the plotly.js version is packages/python/plotly/js/package.json (I know this seems odd to be under packages/python but we're planning to reorganize directories soon to change packages/python to just packages). This is documented in contributing.md.

There are a few codegen commands in setup.py. Which one are you using?

@archmoj
Copy link
Contributor Author

archmoj commented Nov 13, 2024

@marthacryan I am using these steps:
https://github.com/plotly/plotly.py/blob/master/contributing.md#update-to-a-new-version-of-plotlyjs

$ cd packages/python/plotly
$ python setup.py updateplotlyjs

@archmoj
Copy link
Contributor Author

archmoj commented Nov 13, 2024

As a result the traces and attributes we deleted in plotly.js v3.0.0-rc.0 are back e.g.

	plotly/graph_objs/_heatmapgl.py
	plotly/graph_objs/_pointcloud.py
	plotly/graph_objs/heatmapgl/
	plotly/graph_objs/layout/template/data/_heatmapgl.py
	plotly/graph_objs/layout/template/data/_pointcloud.py
	plotly/graph_objs/pointcloud/
	plotly/validators/_heatmapgl.py
	plotly/validators/_pointcloud.py
	plotly/validators/heatmapgl/
	plotly/validators/layout/template/data/_heatmapgl.py
	plotly/validators/layout/template/data/_pointcloud.py
	plotly/validators/pointcloud/

@archmoj
Copy link
Contributor Author

archmoj commented Nov 13, 2024

Resolved by #4871.

@archmoj archmoj closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants