From 105124438274aab0c4f732ae14bdad034d0985f0 Mon Sep 17 00:00:00 2001 From: Steven Kern Date: Fri, 19 Jul 2019 16:07:26 -0500 Subject: [PATCH 1/2] FIX: fix incorrect import in deprecation warning for Scene class --- packages/python/plotly/plotly/graph_objs/_deprecations.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/python/plotly/plotly/graph_objs/_deprecations.py b/packages/python/plotly/plotly/graph_objs/_deprecations.py index a57224c6c81..6c415286931 100644 --- a/packages/python/plotly/plotly/graph_objs/_deprecations.py +++ b/packages/python/plotly/plotly/graph_objs/_deprecations.py @@ -475,7 +475,7 @@ class Scene(dict): """ plotly.graph_objs.Scene is deprecated. Please replace it with one of the following more specific types - - plotly.graph_objs.Scene + - plotly.graph_objs.layout.Scene """ @@ -483,13 +483,13 @@ def __init__(self, *args, **kwargs): """ plotly.graph_objs.Scene is deprecated. Please replace it with one of the following more specific types - - plotly.graph_objs.Scene + - plotly.graph_objs.layout.Scene """ warnings.warn( """plotly.graph_objs.Scene is deprecated. Please replace it with one of the following more specific types - - plotly.graph_objs.Scene + - plotly.graph_objs.layout.Scene """, DeprecationWarning, ) From 396638f0450fe50f51bae51cd3fff95596a73f4f Mon Sep 17 00:00:00 2001 From: Jon Mease Date: Sat, 31 Aug 2019 06:23:16 -0400 Subject: [PATCH 2/2] Update codegen logic to produce correct deprecation message --- packages/python/plotly/codegen/compatibility.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/python/plotly/codegen/compatibility.py b/packages/python/plotly/codegen/compatibility.py index 7dd7fc89d6a..65baf3860ee 100644 --- a/packages/python/plotly/codegen/compatibility.py +++ b/packages/python/plotly/codegen/compatibility.py @@ -26,7 +26,7 @@ "Margin": {"base_type": dict, "new": ["layout"]}, "Marker": {"base_type": dict, "new": ["scatter", "histogram.selected", "etc."]}, "RadialAxis": {"base_type": dict, "new": ["layout", "layout.polar"]}, - "Scene": {"base_type": dict, "new": ["Scene"]}, + "Scene": {"base_type": dict, "new": ["layout"]}, "Stream": {"base_type": dict, "new": ["scatter", "area"]}, "XAxis": {"base_type": dict, "new": ["layout", "layout.scene"]}, "YAxis": {"base_type": dict, "new": ["layout", "layout.scene"]},