Merge pull request #769 from plotly/no-rounding-numeric-reciprocal

nicolaskruchten · web-flow · commit 613ebfc44e33 · 2018-10-18T21:28:29.000-04:00
allow fractional values in NumericReciprocal
diff --git a/src/components/fields/derived.js b/src/components/fields/derived.js
@@ -305,7 +305,7 @@ export const NumericReciprocal = connectToContainer(UnconnectedNumeric, {
     const {fullValue, updatePlot} = plotProps;
 
     if (isNumeric(fullValue)) {
-      plotProps.fullValue = Math.round(1 / fullValue);
+      plotProps.fullValue = 1 / fullValue;
     }
 
     plotProps.updatePlot = v => {
@@ -316,7 +316,7 @@ export const NumericReciprocal = connectToContainer(UnconnectedNumeric, {
       }
     };
 
-    plotProps.min = 1;
+    plotProps.min = 0;
   },
 });
 

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ export const NumericReciprocal = connectToContainer(UnconnectedNumeric, {`
`305`	`305`	`const {fullValue, updatePlot} = plotProps;`
`306`	`306`
`307`	`307`	`if (isNumeric(fullValue)) {`
`308`		`- plotProps.fullValue = Math.round(1 / fullValue);`
	`308`	`+ plotProps.fullValue = 1 / fullValue;`
`309`	`309`	`}`
`310`	`310`
`311`	`311`	`plotProps.updatePlot = v => {`
`@@ -316,7 +316,7 @@ export const NumericReciprocal = connectToContainer(UnconnectedNumeric, {`
`316`	`316`	`}`
`317`	`317`	`};`
`318`	`318`
`319`		`- plotProps.min = 1;`
	`319`	`+ plotProps.min = 0;`
`320`	`320`	`},`
`321`	`321`	`});`
`322`	`322`