Skip to content

Document why use this wrapper? #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evbo opened this issue Sep 18, 2022 · 2 comments
Open

Document why use this wrapper? #291

evbo opened this issue Sep 18, 2022 · 2 comments

Comments

@evbo
Copy link

evbo commented Sep 18, 2022

I get that this is a thin wrapper and I don't want to nitpick but why exactly is it necessary? Could the readme introduce the use for it?

I just created a component, made a div called "graph", and plopped Plotly.newPlot(..) in a useEffect and it gave me a beautiful plot with all features working in this demo:

https://codepen.io/plotly/pen/edZXdj

Of course, this is a trivial example. What am I missing here? It's nice to know these things because I'm also seeing some of the animations features aren't fully implemented in this repo so one naturally wonders is it easier to just use the base library?

@Pablongo24
Copy link

Pablongo24 commented Nov 12, 2022

@evbo after struggling to do several tasks using this wrapper and seeing this issue you posted, I decided to refactor my code to NOT use this wrapper.

It was a bit frustrating to see examples in the main plotly docs that didn't quite work with this wrapper or required too much tweaking.

@damienallen
Copy link

I found the following proposal as a great example of a "thinner" wrapper: #226

Gist: https://gist.github.com/tony/f0938e379aef3c49648a2b1b63e00807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants