Skip to content

Commit 83976be

Browse files
committed
Squashed 'release-tools/' changes from 17dde9e..a6a1a79
kubernetes-csi/csi-release-tools@a6a1a79 Merge kubernetes-csi/csi-release-tools#176 from pohly/go-1.17.3 kubernetes-csi/csi-release-tools@0a2cf63 prow.sh: bump Go to 1.17.3 kubernetes-csi/csi-release-tools@fc29fdd Merge kubernetes-csi/csi-release-tools#141 from pohly/prune-replace-optional kubernetes-csi/csi-release-tools@5b9a1e0 Merge kubernetes-csi/csi-release-tools#175 from jimdaga/patch-1 kubernetes-csi/csi-release-tools@5eeb602 images: use k8s-staging-test-infra/gcb-docker-gcloud kubernetes-csi/csi-release-tools@5489de6 Merge kubernetes-csi/csi-release-tools#174 from mauriciopoppe/bump-kind-version kubernetes-csi/csi-release-tools@0c675d4 Bump kind version to v0.11.1 kubernetes-csi/csi-release-tools@ef69a88 Merge kubernetes-csi/csi-release-tools#173 from nick5616/add-ws2022 kubernetes-csi/csi-release-tools@44c710c added WS2022 to build platforms kubernetes-csi/csi-release-tools@0883be4 Merge kubernetes-csi/csi-release-tools#171 from pohly/example-commands kubernetes-csi/csi-release-tools@02cda51 build.make: support binaries outside of cmd, with optional go.mod kubernetes-csi/csi-release-tools@65922ea Merge kubernetes-csi/csi-release-tools#170 from pohly/canary-snapshot-controller kubernetes-csi/csi-release-tools@c0bdfb3 prow.sh: deploy canary snapshot-controller in canary jobs kubernetes-csi/csi-release-tools@0438f15 Merge kubernetes-csi/csi-release-tools#167 from c0va23/feature/release-armv7-image kubernetes-csi/csi-release-tools@4786f4d Merge kubernetes-csi/csi-release-tools#168 from msau42/update-release-prereq kubernetes-csi/csi-release-tools@6a2dc64 Remove requirement to be top-level approver. Only maintainers membership is required to do a release kubernetes-csi/csi-release-tools@30a4f7b Release armv7 image kubernetes-csi/csi-release-tools@ac8108f Merge kubernetes-csi/csi-release-tools#165 from consideRatio/pr/update-github-links-ref-to-master-to-HEAD kubernetes-csi/csi-release-tools@999b483 docs: make github links reference HEAD instead of main kubernetes-csi/csi-release-tools@fd67069 docs: make github links reference HEAD instead of master kubernetes-csi/csi-release-tools@c0a4fb1 Merge kubernetes-csi/csi-release-tools#164 from anubha-v-ardhan/patch-1 kubernetes-csi/csi-release-tools@9c6a6c0 Master to main cleanup kubernetes-csi/csi-release-tools@682c686 Merge kubernetes-csi/csi-release-tools#162 from pohly/pod-name-via-shell-command kubernetes-csi/csi-release-tools@36a29f5 Merge kubernetes-csi/csi-release-tools#163 from pohly/remove-bazel kubernetes-csi/csi-release-tools@68e43ca prow.sh: remove Bazel build support kubernetes-csi/csi-release-tools@c5f59c5 prow.sh: allow shell commands in CSI_PROW_SANITY_POD kubernetes-csi/csi-release-tools@71c810a Merge kubernetes-csi/csi-release-tools#161 from pohly/mock-test-fixes kubernetes-csi/csi-release-tools@9e438f8 prow.sh: fix mock testing kubernetes-csi/csi-release-tools@d7146c7 Merge kubernetes-csi/csi-release-tools#160 from pohly/kind-update kubernetes-csi/csi-release-tools@4b6aa60 prow.sh: update to KinD v0.11.0 kubernetes-csi/csi-release-tools@7cdc76f Merge kubernetes-csi/csi-release-tools#159 from pohly/fix-deployment-selection kubernetes-csi/csi-release-tools@ef8bd33 prow.sh: more flexible CSI_PROW_DEPLOYMENT, part II kubernetes-csi/csi-release-tools@204bc89 Merge kubernetes-csi/csi-release-tools#158 from pohly/fix-deployment-selection kubernetes-csi/csi-release-tools@61538bb prow.sh: more flexible CSI_PROW_DEPLOYMENT kubernetes-csi/csi-release-tools@2b0e6db Merge kubernetes-csi/csi-release-tools#157 from humblec/csi-release kubernetes-csi/csi-release-tools@a2fcd6d Adding myself to csi reviewers group kubernetes-csi/csi-release-tools@f325590 Merge kubernetes-csi/csi-release-tools#149 from pohly/cluster-logs kubernetes-csi/csi-release-tools@4b03b30 Merge kubernetes-csi/csi-release-tools#155 from pohly/owners kubernetes-csi/csi-release-tools@a6453c8 owners: introduce aliases kubernetes-csi/csi-release-tools@ad83def Merge kubernetes-csi/csi-release-tools#153 from pohly/fix-image-builds kubernetes-csi/csi-release-tools@5561780 build.make: fix image publishng kubernetes-csi/csi-release-tools@29bd39b Merge kubernetes-csi/csi-release-tools#152 from pohly/bump-csi-test kubernetes-csi/csi-release-tools@bc42793 prow.sh: use csi-test v4.2.0 kubernetes-csi/csi-release-tools@b546baa Merge kubernetes-csi/csi-release-tools#150 from mauriciopoppe/windows-multiarch-args kubernetes-csi/csi-release-tools@bfbb6f3 add parameter base_image and addon_image to BUILD_PARAMETERS kubernetes-csi/csi-release-tools@2d61d3b Merge kubernetes-csi/csi-release-tools#151 from humblec/cm kubernetes-csi/csi-release-tools@48e71f0 Replace `which` command ( non standard) with `command -v` builtin kubernetes-csi/csi-release-tools@feb20e2 prow.sh: collect cluster logs kubernetes-csi/csi-release-tools@7b96bea Merge kubernetes-csi/csi-release-tools#148 from dobsonj/add-checkpathcmd-to-prow kubernetes-csi/csi-release-tools@2d2e03b prow.sh: enable -csi.checkpathcmd option in csi-sanity kubernetes-csi/csi-release-tools@09d4151 Merge kubernetes-csi/csi-release-tools#147 from pohly/mock-testing kubernetes-csi/csi-release-tools@74cfbc9 prow.sh: support mock tests kubernetes-csi/csi-release-tools@4a3f110 prow.sh: remove obsolete test suppression kubernetes-csi/csi-release-tools@6616a6b Merge kubernetes-csi/csi-release-tools#146 from pohly/kubernetes-1.21 kubernetes-csi/csi-release-tools@510fb0f prow.sh: support Kubernetes 1.21 kubernetes-csi/csi-release-tools@c63c61b prow.sh: add CSI_PROW_DEPLOYMENT_SUFFIX kubernetes-csi/csi-release-tools@51ac11c Merge kubernetes-csi/csi-release-tools#144 from pohly/pull-jobs kubernetes-csi/csi-release-tools@dd54c92 pull-test.sh: test importing csi-release-tools into other repo kubernetes-csi/csi-release-tools@7d2643a Merge kubernetes-csi/csi-release-tools#143 from pohly/path-setup kubernetes-csi/csi-release-tools@6880b0c prow.sh: avoid creating paths unless really running tests kubernetes-csi/csi-release-tools@b46691a go-get-kubernetes.sh: make replace statement pruning optional kubernetes-csi/csi-release-tools@bc0504a Merge kubernetes-csi/csi-release-tools#140 from jsafrane/remove-unused-k8s-libs kubernetes-csi/csi-release-tools@5b1de1a go-get-kubernetes.sh: remove unused k8s libs kubernetes-csi/csi-release-tools@49b4269 Merge kubernetes-csi/csi-release-tools#120 from pohly/add-kubernetes-release kubernetes-csi/csi-release-tools@a1e1127 Merge kubernetes-csi/csi-release-tools#139 from pohly/kind-for-kubernetes-latest kubernetes-csi/csi-release-tools@1c0fb09 prow.sh: use KinD main for latest Kubernetes kubernetes-csi/csi-release-tools@1d77cfc Merge kubernetes-csi/csi-release-tools#138 from pohly/kind-update-0.10 kubernetes-csi/csi-release-tools@bff2fb7 prow.sh: KinD 0.10.0 kubernetes-csi/csi-release-tools@95eac33 Merge kubernetes-csi/csi-release-tools#137 from pohly/fix-go-version-check kubernetes-csi/csi-release-tools@437e431 verify-go-version.sh: fix check after removal of travis.yml kubernetes-csi/csi-release-tools@1748b16 Merge kubernetes-csi/csi-release-tools#136 from pohly/go-1.16 kubernetes-csi/csi-release-tools@ec844ea remove travis.yml, Go 1.16 kubernetes-csi/csi-release-tools@df76aba Merge kubernetes-csi/csi-release-tools#134 from andyzhangx/add-build-arg kubernetes-csi/csi-release-tools@e314a56 add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3 kubernetes-csi/csi-release-tools@7bc70e5 Merge kubernetes-csi/csi-release-tools#129 from pohly/squash-documentation kubernetes-csi/csi-release-tools@e0b02e7 README.md: document usage of --squash kubernetes-csi/csi-release-tools@316cb95 Merge kubernetes-csi/csi-release-tools#132 from yiyang5055/bugfix/boilerplate kubernetes-csi/csi-release-tools@26e2ab1 fix: default boilerplate path kubernetes-csi/csi-release-tools@1add8c1 Merge kubernetes-csi/csi-release-tools#133 from pohly/kubernetes-1.20-tag kubernetes-csi/csi-release-tools@3e811d6 prow.sh: fix "on-master" prow jobs kubernetes-csi/csi-release-tools@1d60e77 Merge kubernetes-csi/csi-release-tools#131 from pohly/kubernetes-1.20-tag kubernetes-csi/csi-release-tools@9f10459 prow.sh: support building Kubernetes for a specific version kubernetes-csi/csi-release-tools@f7e7ee4 docs: steps for adding testing against new Kubernetes release kubernetes-csi/csi-release-tools@fe1f284 Merge kubernetes-csi/csi-release-tools#121 from kvaps/namespace-check kubernetes-csi/csi-release-tools@8fdf0f7 Merge kubernetes-csi/csi-release-tools#128 from fengzixu/master kubernetes-csi/csi-release-tools@1c94220 fix: fix a bug of csi-sanity kubernetes-csi/csi-release-tools@a4c41e6 Merge kubernetes-csi/csi-release-tools#127 from pohly/fix-boilerplate kubernetes-csi/csi-release-tools@ece0f50 check namespace for snapshot-controller kubernetes-csi/csi-release-tools@dbd8967 verify-boilerplate.sh: fix path to script kubernetes-csi/csi-release-tools@9289fd1 Merge kubernetes-csi/csi-release-tools#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks kubernetes-csi/csi-release-tools@ad29307 Make the spelling and boilerplate checks optional kubernetes-csi/csi-release-tools@5f06d02 Merge kubernetes-csi/csi-release-tools#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests kubernetes-csi/csi-release-tools@48186eb Fix spelling and boilerplate errors kubernetes-csi/csi-release-tools@71690af Merge kubernetes-csi/csi-release-tools#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests kubernetes-csi/csi-release-tools@981be3f Adding spelling and boilerplate checks. kubernetes-csi/csi-release-tools@2bb7525 Merge kubernetes-csi/csi-release-tools#117 from fengzixu/master kubernetes-csi/csi-release-tools@3b6d17b Merge kubernetes-csi/csi-release-tools#118 from pohly/cloud-build-timeout kubernetes-csi/csi-release-tools@9318c6c cloud build: double the timeout, now 1 hour kubernetes-csi/csi-release-tools@4ab8b15 use the tag to replace commit of csi-test kubernetes-csi/csi-release-tools@5d74e45 change the csi-test import path to v4 kubernetes-csi/csi-release-tools@7dcd0a9 upgrade csi-test to v4.0.2 kubernetes-csi/csi-release-tools@86ff580 Merge kubernetes-csi/csi-release-tools#116 from andyzhangx/export-image-name kubernetes-csi/csi-release-tools@c3a9662 allow export image name and registry name kubernetes-csi/csi-release-tools@c6a88c6 Merge kubernetes-csi/csi-release-tools#113 from xing-yang/install_snapshot_controller kubernetes-csi/csi-release-tools@45ec4c6 Fix the install of snapshot CRDs and controller kubernetes-csi/csi-release-tools@5d874cc Merge kubernetes-csi/csi-release-tools#112 from xing-yang/cleanup kubernetes-csi/csi-release-tools@79bbca7 Cleanup kubernetes-csi/csi-release-tools@d437673 Merge kubernetes-csi/csi-release-tools#111 from xing-yang/update_snapshot_v1_rc kubernetes-csi/csi-release-tools@57718f8 Update snapshot CRD version kubernetes-csi/csi-release-tools@4aff857 Merge kubernetes-csi/csi-release-tools#109 from pohly/alpha-test-defaults kubernetes-csi/csi-release-tools@0427289 Merge kubernetes-csi/csi-release-tools#110 from pohly/kind-0.9-bazel-build-workaround kubernetes-csi/csi-release-tools@9a370ab prow.sh: work around "kind build node-image" failure kubernetes-csi/csi-release-tools@522361e prow.sh: only run alpha tests for latest Kubernetes release kubernetes-csi/csi-release-tools@22c0395 Merge kubernetes-csi/csi-release-tools#108 from bnrjee/master kubernetes-csi/csi-release-tools@b5b447b Add go ldflags using LDFLAGS at the time of compilation kubernetes-csi/csi-release-tools@16f4afb Merge kubernetes-csi/csi-release-tools#107 from pohly/kind-update kubernetes-csi/csi-release-tools@7bcee13 prow.sh: update to kind 0.9, support Kubernetes 1.19 kubernetes-csi/csi-release-tools@df518fb prow.sh: usage of Bazel optional kubernetes-csi/csi-release-tools@c3afd42 Merge kubernetes-csi/csi-release-tools#104 from xing-yang/snapshot kubernetes-csi/csi-release-tools@dde93b2 Update to snapshot-controller v3.0.0 kubernetes-csi/csi-release-tools@a0f195c Merge kubernetes-csi/csi-release-tools#106 from msau42/fix-canary kubernetes-csi/csi-release-tools@7100c12 Only set staging registry when running canary job kubernetes-csi/csi-release-tools@b3c65f9 Merge kubernetes-csi/csi-release-tools#99 from msau42/add-release-process kubernetes-csi/csi-release-tools@e53f3e8 Merge kubernetes-csi/csi-release-tools#103 from msau42/fix-canary kubernetes-csi/csi-release-tools@d129462 Document new method for adding CI jobs are new K8s versions kubernetes-csi/csi-release-tools@e73c2ce Use staging registry for canary tests kubernetes-csi/csi-release-tools@2c09846 Add cleanup instructions to release-notes generation kubernetes-csi/csi-release-tools@60e1cd3 Merge kubernetes-csi/csi-release-tools#98 from pohly/kubernetes-1-19-fixes kubernetes-csi/csi-release-tools@0979c09 prow.sh: fix E2E suite for Kubernetes >= 1.18 kubernetes-csi/csi-release-tools@3b4a2f1 prow.sh: fix installing Go for Kubernetes 1.19.0 kubernetes-csi/csi-release-tools@1fbb636 Merge kubernetes-csi/csi-release-tools#97 from pohly/go-1.15 kubernetes-csi/csi-release-tools@82d108a switch to Go 1.15 kubernetes-csi/csi-release-tools@d8a2530 Merge kubernetes-csi/csi-release-tools#95 from msau42/add-release-process kubernetes-csi/csi-release-tools@843bddc Add steps on promoting release images kubernetes-csi/csi-release-tools@0345a83 Merge kubernetes-csi/csi-release-tools#94 from linux-on-ibm-z/bump-timeout kubernetes-csi/csi-release-tools@1fdf2d5 cloud build: bump timeout in Prow job kubernetes-csi/csi-release-tools@41ec6d1 Merge kubernetes-csi/csi-release-tools#93 from animeshk08/patch-1 kubernetes-csi/csi-release-tools@5a54e67 filter-junit: Fix gofmt error kubernetes-csi/csi-release-tools@0676fcb Merge kubernetes-csi/csi-release-tools#92 from animeshk08/patch-1 kubernetes-csi/csi-release-tools@36ea4ff filter-junit: Fix golint error kubernetes-csi/csi-release-tools@f5a4203 Merge kubernetes-csi/csi-release-tools#91 from cyb70289/arm64 kubernetes-csi/csi-release-tools@43e50d6 prow.sh: enable building arm64 image kubernetes-csi/csi-release-tools@0d5bd84 Merge kubernetes-csi/csi-release-tools#90 from pohly/k8s-staging-sig-storage kubernetes-csi/csi-release-tools@3df86b7 cloud build: k8s-staging-sig-storage kubernetes-csi/csi-release-tools@c5fd961 Merge kubernetes-csi/csi-release-tools#89 from pohly/cloud-build-binfmt kubernetes-csi/csi-release-tools@db0c2a7 cloud build: initialize support for running commands in Dockerfile kubernetes-csi/csi-release-tools@be902f4 Merge kubernetes-csi/csi-release-tools#88 from pohly/multiarch-windows-fix kubernetes-csi/csi-release-tools@340e082 build.make: optional inclusion of Windows in multiarch images kubernetes-csi/csi-release-tools@5231f05 build.make: properly declare push-multiarch kubernetes-csi/csi-release-tools@4569f27 build.make: fix push-multiarch ambiguity git-subtree-dir: release-tools git-subtree-split: a6a1a7979bf3ebc2bb10d0e33dd11ab281d6d39e
1 parent 17dde9e commit 83976be

27 files changed

+1102
-296
lines changed

.prow.sh

+16
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,23 @@
11
#! /bin/bash -e
2+
3+
# Copyright 2021 The Kubernetes Authors.
4+
#
5+
# Licensed under the Apache License, Version 2.0 (the "License");
6+
# you may not use this file except in compliance with the License.
7+
# You may obtain a copy of the License at
28
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
317
# This is for testing csi-release-tools itself in Prow. All other
418
# repos use prow.sh for that, but as csi-release-tools isn't a normal
519
# repo with some Go code in it, it has a custom Prow test script.
620

721
./verify-shellcheck.sh "$(pwd)"
22+
./verify-spelling.sh "$(pwd)"
23+
./verify-boilerplate.sh "$(pwd)"

KUBERNETES_CSI_OWNERS_ALIASES

+45
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
2+
3+
aliases:
4+
5+
# SIG-Storage chairs and leads should always have approval rights in all repos.
6+
# Others may be added as needed here or in each repo.
7+
kubernetes-csi-approvers:
8+
- jsafrane
9+
- msau42
10+
- saad-ali
11+
- xing-yang
12+
13+
# Reviewers are automatically assigned to new PRs. The following
14+
# reviewers will be active in all repos. Other reviewers can be
15+
# added in each repo.
16+
#
17+
# Reviewers are encouraged to set the "Busy" flag in their GitHub status
18+
# when they are temporarily unable to review PRs.
19+
kubernetes-csi-reviewers:
20+
- andyzhangx
21+
- chrishenzie
22+
- ggriffiths
23+
- gnufied
24+
- humblec
25+
- j-griffith
26+
- Jiawei0227
27+
- jingxu97
28+
- jsafrane
29+
- pohly
30+
- xing-yang
31+
32+
# This documents who previously contributed to Kubernetes-CSI
33+
# as approver.
34+
emeritus_approver:
35+
- lpabon
36+
- sbezverk
37+
- vladimirvivien
38+
39+
# This documents who previously contributed to Kubernetes-CSI
40+
# as reviewer.
41+
emeritus_reviewer:
42+
- lpabon
43+
- saad-ali
44+
- sbezverk
45+
- vladimirvivien

OWNERS

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
22

33
approvers:
4-
- saad-ali
5-
- msau42
4+
- kubernetes-csi-approvers
65
- pohly
76

87
reviewers:
9-
- saad-ali
10-
- msau42
11-
- pohly
8+
- kubernetes-csi-reviewers

OWNERS_ALIASES

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
KUBERNETES_CSI_OWNERS_ALIASES

README.md

+16-5
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ The expected repository layout is:
2121
Dockerfile in the root when only building a single command
2222
- `Makefile` - includes `release-tools/build.make` and sets
2323
configuration variables
24-
- `.travis.yml` - a symlink to `release-tools/.travis.yml`
24+
- `.prow.sh` script which imports `release-tools/prow.sh`
25+
and may contain further customization
26+
- `.cloudbuild.sh` and `cloudbuild.yaml` as symlinks to
27+
the corresponding files in `release-tools` or (if necessary)
28+
as custom files
2529

2630
To create a release, tag a certain revision with a name that
2731
starts with `v`, for example `v1.0.0`, then `make push`
@@ -38,16 +42,23 @@ images. Building from master creates the main `canary` image.
3842
Sharing and updating
3943
--------------------
4044

41-
[`git subtree`](https://github.com/git/git/blob/master/contrib/subtree/git-subtree.txt)
45+
[`git subtree`](https://github.com/git/git/blob/HEAD/contrib/subtree/git-subtree.txt)
4246
is the recommended way of maintaining a copy of the rules inside the
4347
`release-tools` directory of a project. This way, it is possible to make
4448
changes also locally, test them and then push them back to the shared
4549
repository at a later time.
4650

51+
We no longer care about importing the full commit history, so `--squash` should be used
52+
when submitting a `release-tools` update. Also make sure that the PR for that
53+
contains the automatically generated commit message in the PR description.
54+
It contains the list of individual commits that were squashed. The script from
55+
https://github.com/kubernetes-csi/csi-release-tools/issues/7 can create such
56+
PRs automatically.
57+
4758
Cheat sheet:
4859

49-
- `git subtree add --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master` - add release tools to a repo which does not have them yet (only once)
50-
- `git subtree pull --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master` - update local copy to latest upstream (whenever upstream changes)
60+
- `git subtree add --squash --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master` - add release tools to a repo which does not have them yet (only once)
61+
- `git subtree pull --squash --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master` - update local copy to latest upstream (whenever upstream changes)
5162
- edit, `git commit`, `git subtree push --prefix=release-tools [email protected]:<user>/csi-release-tools.git <my-new-or-existing-branch>` - push to a new branch before submitting a PR
5263

5364
verify-shellcheck.sh
@@ -78,7 +89,7 @@ main
7889

7990
All Kubernetes-CSI repos are expected to switch to Prow. For details
8091
on what is enabled in Prow, see
81-
https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-csi
92+
https://github.com/kubernetes/test-infra/tree/HEAD/config/jobs/kubernetes-csi
8293

8394
Test results for periodic jobs are visible in
8495
https://testgrid.k8s.io/sig-storage-csi-ci

SECURITY_CONTACTS

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# to for triaging and handling of incoming issues.
55
#
66
# The below names agree to abide by the
7-
# [Embargo Policy](https://github.com/kubernetes/sig-release/blob/master/security-release-process-documentation/security-release-process.md#embargo-policy)
7+
# [Embargo Policy](https://github.com/kubernetes/sig-release/blob/HEAD/security-release-process-documentation/security-release-process.md#embargo-policy)
88
# and will be removed and replaced if they violate that agreement.
99
#
1010
# DO NOT REPORT SECURITY VULNERABILITIES DIRECTLY TO THESE NAMES, FOLLOW THE

SIDECAR_RELEASE_PROCESS.md

+70-19
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,8 @@ The release manager must:
99
* Be a member of the kubernetes-csi organization. Open an
1010
[issue](https://github.com/kubernetes/org/issues/new?assignees=&labels=area%2Fgithub-membership&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E) in
1111
kubernetes/org to request membership
12-
* Be a top level approver for the repository. To become a top level approver,
13-
the candidate must demonstrate ownership and deep knowledge of the repository
14-
through active maintainence, responding to and fixing issues, reviewing PRs,
15-
test triage.
16-
* Be part of the maintainers or admin group for the repository. admin is a
17-
superset of maintainers, only maintainers level is required for cutting a
18-
release. Membership can be requested by submitting a PR to kubernetes/org.
12+
* Be part of the maintainers group for the repository.
13+
Membership can be requested by submitting a PR to kubernetes/org.
1914
[Example](https://github.com/kubernetes/org/pull/1467)
2015

2116
## Updating CI Jobs
@@ -31,18 +26,19 @@ naming convention `<hostpath-deployment-version>-on-<kubernetes-version>`.
3126
1. "-on-master" jobs are the closest reflection to the new Kubernetes version.
3227
1. Fixes to our prow.sh CI script can be tested in the [CSI hostpath
3328
repo](https://github.com/kubernetes-csi/csi-driver-host-path) by modifying
34-
[prow.sh](https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/release-tools/prow.sh)
29+
[prow.sh](https://github.com/kubernetes-csi/csi-driver-host-path/blob/HEAD/release-tools/prow.sh)
3530
along with any overrides in
36-
[.prow.sh](https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/.prow.sh)
31+
[.prow.sh](https://github.com/kubernetes-csi/csi-driver-host-path/blob/HEAD/.prow.sh)
3732
to mirror the failing environment. Once e2e tests are passing (verify-unit tests
3833
will fail), then the prow.sh changes can be submitted to [csi-release-tools](https://github.com/kubernetes-csi/csi-release-tools).
3934
1. Changes can then be updated in all the sidecar repos and hostpath driver repo
4035
by following the [update
41-
instructions](https://github.com/kubernetes-csi/csi-release-tools/blob/master/README.md#sharing-and-updating).
42-
1. New pull and CI jobs are configured by
43-
[gen-jobs.sh](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/gen-jobs.sh).
44-
New pull jobs that have been unverified should be initially made optional.
45-
[Example](https://github.com/kubernetes/test-infra/pull/15055)
36+
instructions](https://github.com/kubernetes-csi/csi-release-tools/blob/HEAD/README.md#sharing-and-updating).
37+
1. New pull and CI jobs are configured by adding new K8s versions to the top of
38+
[gen-jobs.sh](https://github.com/kubernetes/test-infra/blob/HEAD/config/jobs/kubernetes-csi/gen-jobs.sh).
39+
New pull jobs that have been unverified should be initially made optional by
40+
setting the new K8s version as
41+
[experimental](https://github.com/kubernetes/test-infra/blob/a1858f46d6014480b130789df58b230a49203a64/config/jobs/kubernetes-csi/gen-jobs.sh#L40).
4642
1. Once new pull and CI jobs have been verified, and the new Kubernetes version
4743
is released, we can make the optional jobs required, and also remove the
4844
Kubernetes versions that are no longer supported.
@@ -51,17 +47,22 @@ naming convention `<hostpath-deployment-version>-on-<kubernetes-version>`.
5147
1. Identify all issues and ongoing PRs that should go into the release, and
5248
drive them to resolution.
5349
1. Download v2.8+ [K8s release notes
54-
generator](https://github.com/kubernetes/release/tree/master/cmd/release-notes)
50+
generator](https://github.com/kubernetes/release/tree/HEAD/cmd/release-notes)
5551
1. Generate release notes for the release. Replace arguments with the relevant
5652
information.
53+
* Clean up old cached information (also needed if you are generating release
54+
notes for multiple repos)
55+
```bash
56+
rm -rf /tmp/k8s-repo
57+
```
5758
* For new minor releases on master:
58-
```
59+
```bash
5960
GITHUB_TOKEN=<token> release-notes --discover=mergebase-to-latest
6061
--github-org=kubernetes-csi --github-repo=external-provisioner
6162
--required-author="" --output out.md
6263
```
6364
* For new patch releases on a release branch:
64-
```
65+
```bash
6566
GITHUB_TOKEN=<token> release-notes --discover=patch-to-latest --branch=release-1.1
6667
--github-org=kubernetes-csi --github-repo=external-provisioner
6768
--required-author="" --output out.md
@@ -86,9 +87,59 @@ naming convention `<hostpath-deployment-version>-on-<kubernetes-version>`.
8687
[external-provisioner example](https://github.com/kubernetes-csi/external-provisioner/releases/new)
8788
1. If release was a new major/minor version, create a new `release-<minor>`
8889
branch at that commit.
90+
1. Check [image build status](https://k8s-testgrid.appspot.com/sig-storage-image-build).
91+
1. Promote images from k8s-staging-sig-storage to k8s.gcr.io/sig-storage. From
92+
the [k8s image
93+
repo](https://github.com/kubernetes/k8s.io/tree/HEAD/k8s.gcr.io/images/k8s-staging-sig-storage),
94+
run `./generate.sh > images.yaml`, and send a PR with the updated images.
95+
Once merged, the image promoter will copy the images from staging to prod.
8996
1. Update [kubernetes-csi/docs](https://github.com/kubernetes-csi/docs) sidecar
9097
and feature pages with the new released version.
9198
1. After all the sidecars have been released, update
92-
CSI hostpath driver with the new sidecars in the [CSI repo](https://github.com/kubernetes-csi/csi-driver-host-path/tree/master/deploy)
99+
CSI hostpath driver with the new sidecars in the [CSI repo](https://github.com/kubernetes-csi/csi-driver-host-path/tree/HEAD/deploy)
93100
and [k/k
94-
in-tree](https://github.com/kubernetes/kubernetes/tree/master/test/e2e/testing-manifests/storage-csi/hostpath/hostpath)
101+
in-tree](https://github.com/kubernetes/kubernetes/tree/HEAD/test/e2e/testing-manifests/storage-csi/hostpath/hostpath)
102+
103+
## Adding support for a new Kubernetes release
104+
105+
1. Add the new release to `k8s_versions` in
106+
https://github.com/kubernetes/test-infra/blob/090dec5dd535d5f61b7ba52e671a810f5fc13dfd/config/jobs/kubernetes-csi/gen-jobs.sh#L25
107+
to enable generating a job for it. Set `experimental_k8s_version`
108+
in
109+
https://github.com/kubernetes/test-infra/blob/090dec5dd535d5f61b7ba52e671a810f5fc13dfd/config/jobs/kubernetes-csi/gen-jobs.sh#L40
110+
to ensure that the new jobs aren't run for PRs unless explicitly
111+
requested. Generate and submit the new jobs.
112+
1. Create a test PR to try out the new job in some repo with `/test
113+
pull-kubernetes-csi-<repo>-<x.y>-on-kubernetes-<x.y>` where x.y
114+
matches the Kubernetes release. Alternatively, run .prow.sh in that
115+
repo locally with `CSI_PROW_KUBERNETES_VERSION=x.y.z`.
116+
1. Optional: update to a [new
117+
release](https://github.com/kubernetes-sigs/kind/tags) of kind with
118+
pre-built images for the new Kubernetes release. This is optional
119+
if the current version of kind is able to build images for the new
120+
Kubernetes release. However, jobs require less resources when they
121+
don't need to build those images from the Kubernetes source code.
122+
This change needs to be tried out in a PR against a component
123+
first, then get submitted against csi-release-tools.
124+
1. Optional: propagate the updated csi-release-tools to all components
125+
with the script from
126+
https://github.com/kubernetes-csi/csi-release-tools/issues/7#issuecomment-707025402
127+
1. Once it is likely to work in all components, unset
128+
`experimental_k8s_version` and submit the updated jobs.
129+
1. Once all sidecars for the new Kubernetes release are released,
130+
either bump the version number of the images in the existing
131+
[csi-driver-host-path
132+
deployments](https://github.com/kubernetes-csi/csi-driver-host-path/tree/HEAD/deploy)
133+
and/or create a new deployment, depending on what Kubernetes
134+
release an updated sidecar is compatible with. If no new deployment
135+
is needed, then add a symlink to document that there intentionally
136+
isn't a separate deployment. This symlink is not needed for Prow
137+
testing because that will use "kubernetes-latest" as fallback.
138+
Update that link when creating a new deployment.
139+
1. Create a new csi-driver-host-path release.
140+
1. Bump `CSI_PROW_DRIVER_VERSION` in prow.sh to that new release and
141+
(eventually) roll that change out to all repos by updating
142+
`release-tools` in them. This is used when testing manually. The
143+
Prow jobs override that value, so also update
144+
`hostpath_driver_version` in
145+
https://github.com/kubernetes/test-infra/blob/91b04e6af3a40a9bcff25aa030850a4721e2dd2b/config/jobs/kubernetes-csi/gen-jobs.sh#L46-L47
+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Copyright YEAR The Kubernetes Authors.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.

boilerplate/boilerplate.Makefile.txt

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Copyright YEAR The Kubernetes Authors.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.

boilerplate/boilerplate.bzl.txt

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Copyright YEAR The Kubernetes Authors.
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.

boilerplate/boilerplate.go.txt

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
/*
2+
Copyright YEAR The Kubernetes Authors.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/

0 commit comments

Comments
 (0)