Only checking if we've exceeded threshold if the current value fails

Author: pimms

Sources/SnapshotTesting/Snapshotting/NSImage.swift

@@ -84,9 +84,11 @@ private func compare(_ old: NSImage, _ new: NSImage, precision: Float) -> Bool {
   var offset = 0
   while offset < pixelCount * 4 {
     if p1[offset] != p2[offset] {
-        differentPixelCount += 1
+      differentPixelCount += 1
+      if differentPixelCount > threshold {
+        return false
+      }
     }
-    if differentPixelCount > threshold { return false }
     offset += 1
   }
   return true

Sources/SnapshotTesting/Snapshotting/UIImage.swift

@@ -105,8 +105,12 @@ private func compare(_ old: UIImage, _ new: UIImage, precision: Float) -> Bool {
 
   var byte = 0
   while byte < byteCount {
-    if oldBytes[byte] != newerBytes[byte] { differentPixelCount += 1 }
-    if differentPixelCount >= threshold { return false }
+    if oldBytes[byte] != newerBytes[byte] {
+      differentPixelCount += 1
+      if differentPixelCount >= threshold {
+        return false
+      }
+    }
     byte += 1
   }
   return true