Skip to content

[Feature] Record mode that only records significant differences #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n8chur opened this issue Jun 15, 2022 · 0 comments
Open

[Feature] Record mode that only records significant differences #607

n8chur opened this issue Jun 15, 2022 · 0 comments

Comments

@n8chur
Copy link

n8chur commented Jun 15, 2022

Describe the Issue

It'd be great to have access to a record mode where reference images are only written to disk if the Diffing implementation used considers the difference a failure.

We are currently running snapshot tests on a Intel and M1 machines in my organization (using the Diffing implementation that allows for subpixel precision in #571), and with record mode on today, reference images are saved to disk if there is any difference, regardless of whether the difference would cause a test failure.

We're working around this issue by running the test twice when record mode is requested—once with record mode off, and then again if the test fails with record mode on. It'd be great to avoid needing to run the test twice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant