-
Notifications
You must be signed in to change notification settings - Fork 608
Running tests with Xcode 14.1 changes frame? #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We also experience failures migrating from Xcode 13 to Xcode 14. For most cases there is no visible difference yet still the majority of tests fail. So I'd be also interested how others approach this. |
actually, i see some 2px frame changes in Xcode 14 🤔 but to your point @mathaeus , I also wonder if users just re-record the changes that occurred as a result of Xcode major version upgrade (given that there are no visible or very little visible changes) |
What I ended up doing was:
|
@chriisong Generally, yes, this is what we do at my team that uses https://github.com/uber/ios-snapshot-test-case which suffers the same issue. Differences between Xcode versions can subtly influence the way views are laid out. Oftentimes, we end up seeing this as text characters being shifted slightly by a single pixel. |
SnapshotTesting uses GitHub issues for bugs. For more general discussion and help, please use GitHub Discussions.
I've been using 13.4 for a while now, just tried running our app with 14.1 and saw that all my
recursiveDescription
assertions failed. Is this what everyone experienced with upgrading to Xccode 14.x? I didn't change anything else on my end except to open my project with Xcode 14.1The text was updated successfully, but these errors were encountered: