Fix typo in setrefs.c

sfrost · sfrost · commit 1e460d4bd633 · 2015-09-10T09:22:03.000-04:00
We're adding OIDs, not TIDs, to invalItems.

Pointed out by Etsuro Fujita.

Back-patch to all supported branches.
diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c
@@ -1243,7 +1243,7 @@ copyVar(Var *var)
  * This is code that is common to all variants of expression-fixing.
  * We must look up operator opcode info for OpExpr and related nodes,
  * add OIDs from regclass Const nodes into root->glob->relationOids, and
- * add catalog TIDs for user-defined functions into root->glob->invalItems.
+ * add catalog OIDs for user-defined functions into root->glob->invalItems.
  * We also fill in column index lists for GROUPING() expressions.
  *
  * We assume it's okay to update opcode info in-place.  So this could possibly

Original file line number	Diff line number	Diff line change
`@@ -1243,7 +1243,7 @@ copyVar(Var *var)`
`1243`	`1243`	`* This is code that is common to all variants of expression-fixing.`
`1244`	`1244`	`* We must look up operator opcode info for OpExpr and related nodes,`
`1245`	`1245`	`* add OIDs from regclass Const nodes into root->glob->relationOids, and`
`1246`		`- * add catalog TIDs for user-defined functions into root->glob->invalItems.`
	`1246`	`+ * add catalog OIDs for user-defined functions into root->glob->invalItems.`
`1247`	`1247`	`* We also fill in column index lists for GROUPING() expressions.`
`1248`	`1248`	`*`
`1249`	`1249`	`* We assume it's okay to update opcode info in-place. So this could possibly`