fix function handle_modification_query(), refactoring (+function build_part_tuple_map())

Author: funbringer

Makefile

@@ -25,6 +25,7 @@ REGRESS = pathman_basic \
 		  pathman_cte \
 		  pathman_bgw \
 		  pathman_inserts \
+		  pathman_updates \
 		  pathman_domains \
 		  pathman_interval \
 		  pathman_callbacks \

expected/pathman_updates.out

@@ -0,0 +1,64 @@
+\set VERBOSITY terse
+SET search_path = 'public';
+CREATE EXTENSION pg_pathman;
+CREATE SCHEMA test_updates;
+/*
+ * Test UPDATEs on a partition with different TupleDescriptor.
+ */
+/* create partitioned table */
+CREATE TABLE test_updates.test(a FLOAT4, val INT4 NOT NULL, b FLOAT8);
+INSERT INTO test_updates.test SELECT i, i, i FROM generate_series(1, 100) AS i;
+SELECT create_range_partitions('test_updates.test', 'val', 1, 10);
+NOTICE:  sequence "test_seq" does not exist, skipping
+ create_range_partitions 
+-------------------------
+                      10
+(1 row)
+
+/* drop column 'a' */
+ALTER TABLE test_updates.test DROP COLUMN a;
+/* append new partition */
+SELECT append_range_partition('test_updates.test');
+ append_range_partition 
+------------------------
+ test_updates.test_11
+(1 row)
+
+INSERT INTO test_updates.test_11 (val, b) VALUES (101, 10);
+/* tuple descs are the same */
+EXPLAIN (COSTS OFF) UPDATE test_updates.test SET b = 0 WHERE val = 1;
+        QUERY PLAN         
+---------------------------
+ Update on test_1
+   ->  Seq Scan on test_1
+         Filter: (val = 1)
+(3 rows)
+
+UPDATE test_updates.test SET b = 0 WHERE val = 1 RETURNING *, tableoid::REGCLASS;
+ val | b |      tableoid       
+-----+---+---------------------
+   1 | 0 | test_updates.test_1
+(1 row)
+
+/* tuple descs are different */
+EXPLAIN (COSTS OFF) UPDATE test_updates.test SET b = 0 WHERE val = 101;
+         QUERY PLAN          
+-----------------------------
+ Update on test
+   Update on test
+   Update on test_11
+   ->  Seq Scan on test
+         Filter: (val = 101)
+   ->  Seq Scan on test_11
+         Filter: (val = 101)
+(7 rows)
+
+UPDATE test_updates.test SET b = 0 WHERE val = 101 RETURNING *, tableoid::REGCLASS;
+ val | b |       tableoid       
+-----+---+----------------------
+ 101 | 0 | test_updates.test_11
+(1 row)
+
+DROP SCHEMA test_updates CASCADE;
+NOTICE:  drop cascades to 13 other objects
+DROP EXTENSION pg_pathman;

sql/pathman_updates.sql

@@ -0,0 +1,37 @@
+\set VERBOSITY terse
+
+SET search_path = 'public';
+CREATE EXTENSION pg_pathman;
+CREATE SCHEMA test_updates;
+
+
+/*
+ * Test UPDATEs on a partition with different TupleDescriptor.
+ */
+
+/* create partitioned table */
+CREATE TABLE test_updates.test(a FLOAT4, val INT4 NOT NULL, b FLOAT8);
+INSERT INTO test_updates.test SELECT i, i, i FROM generate_series(1, 100) AS i;
+SELECT create_range_partitions('test_updates.test', 'val', 1, 10);
+
+/* drop column 'a' */
+ALTER TABLE test_updates.test DROP COLUMN a;
+
+/* append new partition */
+SELECT append_range_partition('test_updates.test');
+INSERT INTO test_updates.test_11 (val, b) VALUES (101, 10);
+
+
+/* tuple descs are the same */
+EXPLAIN (COSTS OFF) UPDATE test_updates.test SET b = 0 WHERE val = 1;
+UPDATE test_updates.test SET b = 0 WHERE val = 1 RETURNING *, tableoid::REGCLASS;
+
+
+/* tuple descs are different */
+EXPLAIN (COSTS OFF) UPDATE test_updates.test SET b = 0 WHERE val = 101;
+UPDATE test_updates.test SET b = 0 WHERE val = 101 RETURNING *, tableoid::REGCLASS;
+
+
+
+DROP SCHEMA test_updates CASCADE;
+DROP EXTENSION pg_pathman;