Skip to content

make test fails #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vitcpp opened this issue Jul 7, 2023 · 4 comments
Closed

make test fails #28

vitcpp opened this issue Jul 7, 2023 · 4 comments

Comments

@vitcpp
Copy link
Contributor

vitcpp commented Jul 7, 2023

No description provided.

@vitcpp
Copy link
Contributor Author

vitcpp commented Jul 7, 2023

I also found a possible fix for make test. If to replace init_test with init in TESTS = ... everything should be ok. In this issue we should check what is the difference between sql/init.sql and sql/init_test.sql. May be, sql/init.sql is enough?

image

@esabol
Copy link
Contributor

esabol commented Jul 7, 2023

I have a fix for the USE_HEALPIX=0 case, but I can't compile the code with USE_HEALPIX=1 to get the expected output in that scenario. If someone could compile PR #26 with HEALPix support and upload the regression.diffs file for make test, I could include include the fix for make test in PR #26, but maybe it should be a separate PR?

Oh, I just realized I could leverage the Travis CI to do this! I'll try doing that.

@esabol
Copy link
Contributor

esabol commented Jul 7, 2023

I also found a possible fix for make test. If to replace init_test with init in TESTS = ... everything should be ok. In this issue we should check what is the difference between sql/init.sql and sql/init_test.sql. May be, sql/init.sql is enough?

Oh, interesting! That would simplify things, certainly. I'll take a look.

@vitcpp
Copy link
Contributor Author

vitcpp commented Jul 11, 2023

The issue is fixed by @esabol in one PR with issue #26

@vitcpp vitcpp closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants