Skip to content

spherepoly_check (sline_sline_pos) is not working properly #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ggnmstr opened this issue Jul 29, 2023 · 0 comments
Closed

spherepoly_check (sline_sline_pos) is not working properly #35

ggnmstr opened this issue Jul 29, 2023 · 0 comments

Comments

@ggnmstr
Copy link
Contributor

ggnmstr commented Jul 29, 2023

Current state of spherepoly_check allows user to create polygons like spoly'{(0d,1d),(0d,2d),(0d,3d)}', which is incorrect because all points lie on the same meridian.
The root of this problem may be in sline_sline_pos fucntion, because it determines relations between sline'(0d,1d),(0d,2d)' and sline'(0d,3d),(0d,1d)' as "connects", which is also incorrect.

Screenshot from 2023-07-29 15-23-52
2 last log messages: pos=5 means lines are connected, but they actually overlap.

Solution I found is to change the order of block of code in sline_sline_pos responsible for detecting overlap and connection.
I created pull request with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant