Skip to content

Add BRIN support for spoint and sbox? #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
esabol opened this issue Aug 14, 2023 · 3 comments · Fixed by #55
Closed

Add BRIN support for spoint and sbox? #52

esabol opened this issue Aug 14, 2023 · 3 comments · Fixed by #55
Assignees

Comments

@esabol
Copy link
Contributor

esabol commented Aug 14, 2023

Would incorporating this PR be useful to anyone? It was fully working but never merged. It seems a waste to not retain this functionality, and it could be a real benefit when dealing with very large tables with millions of points.

See akorotkov/pgsphere#8 and this comment.

@vitcpp vitcpp assigned vitcpp and unassigned vitcpp Aug 15, 2023
@vitcpp vitcpp linked a pull request Aug 16, 2023 that will close this issue
@gbroccolo
Copy link

Hi, I see @vitcpp already opened a PR here (will leave comments there eventually). I'm happy to help if needed.

@vitcpp
Copy link
Contributor

vitcpp commented Aug 17, 2023

@gbroccolo Thank you for the patch! I preserved your authorship of the patch with some code adjustments. I believe, you don't mind if the patch will be applied in this repo. We also appreciate it if you will open some new PRs in this repo that seems to be the only alive repo of the pgSphere project.

@gbroccolo
Copy link

Hi @vitcpp fine. Will try to open new PRs, each one for each spherical geometry, any sooner. I will probably start with the circular type, as requested by @esabol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants