fix arbiter port assignment logic

Author: kelvich

arbiter.c

@@ -507,11 +507,7 @@ static void MtmOpenConnections()
 	}
 	for (i = 0; i < nNodes; i++) {
 		if (i+1 != MtmNodeId && i < Mtm->nAllNodes) { 
-			int arbiterPort = Mtm->nodes[i].con.arbiterPort;
-			if (arbiterPort == 0) {
-				arbiterPort = MtmArbiterPort + i + 1;
-			}
-			sockets[i] = MtmConnectSocket(i, arbiterPort, MtmConnectTimeout);
+			sockets[i] = MtmConnectSocket(i, Mtm->nodes[i].con.arbiterPort, MtmConnectTimeout);
 			if (sockets[i] < 0) { 
 				MtmOnNodeDisconnect(i+1);
 			} 
@@ -542,13 +538,13 @@ static bool MtmSendToNode(int node, void const* buf, int size)
 			BIT_CLEAR(Mtm->reconnectMask, node);
 			MtmUnlock();
 		}
-		if (sockets[node] < 0 || !MtmWriteSocket(sockets[node], buf, size)) { 
+		if (sockets[node] < 0 || !MtmWriteSocket(sockets[node], buf, size)) {
 			if (sockets[node] >= 0) { 
 				elog(WARNING, "Arbiter fail to write to node %d: %d", node+1, errno);
 				close(sockets[node]);
 				sockets[node] = -1;
 			}
-			sockets[node] = MtmConnectSocket(node, MtmArbiterPort + node + 1, MtmReconnectTimeout);
+			sockets[node] = MtmConnectSocket(node, Mtm->nodes[node].con.arbiterPort, MtmReconnectTimeout);
 			if (sockets[node] < 0) { 
 				MtmOnNodeDisconnect(node+1);
 				result = false;
@@ -638,7 +634,7 @@ static void MtmAcceptIncomingConnections()
 	}
 	sock_inet.sin_family = AF_INET;
 	sock_inet.sin_addr.s_addr = htonl(INADDR_ANY);
-	sock_inet.sin_port = htons(MtmArbiterPort + MtmNodeId);
+	sock_inet.sin_port = htons(MtmArbiterPort);
 
     gateway = socket(sock_inet.sin_family, SOCK_STREAM, 0);
 	if (gateway < 0) {

multimaster.c

@@ -2161,8 +2161,10 @@ void MtmUpdateNodeConnectionInfo(MtmConnectionInfo* conn, char const* connStr)
 			elog(ERROR, "Invalid arbiter port: %s", port+12);
 		}
 	} else { 
-		conn->arbiterPort = 0;
+		conn->arbiterPort = MULTIMASTER_DEFAULT_ARBITER_PORT;
 	}
+
+	elog(WARNING, "Using arbiter port: %d", conn->arbiterPort);
 }
 
 static void MtmSplitConnStrs(void)
@@ -2647,7 +2649,7 @@ _PG_init(void)
 		"Base value for assigning arbiter ports",
 		NULL,
 		&MtmArbiterPort,
-		54320,
+		MULTIMASTER_DEFAULT_ARBITER_PORT,
 	    0,
 		INT_MAX,
 		PGC_BACKEND,

multimaster.h

@@ -58,6 +58,8 @@
 #define MULTIMASTER_BROADCAST_SERVICE   "mtm_broadcast"
 #define MULTIMASTER_ADMIN               "mtm_admin"
 
+#define MULTIMASTER_DEFAULT_ARBITER_PORT 5433
+
 #define MB (1024*1024L)
 
 #define USEC_TO_MSEC(t) ((t)/1000)

tests2/docker-compose.yml

@@ -10,7 +10,7 @@ services:
       POSTGRES_USER: 'pg'
       POSTGRES_DB: 'regression'
       NODE_ID: 1
-      CONNSTR: |
+      CONNSTRS: >-
         dbname=regression user=pg host=node1 arbiterport=5433,
         dbname=regression user=pg host=toxi port=12000 arbiterport=12001,
         dbname=regression user=pg host=toxi port=13000 arbiterport=13001
@@ -25,7 +25,7 @@ services:
       POSTGRES_USER: 'pg'
       POSTGRES_DB: 'regression'
       NODE_ID: 2
-      CONNSTR: |
+      CONNSTRS: >-
         dbname=regression user=pg host=toxi port=21000 arbiterport=21001,
         dbname=regression user=pg host=node2 arbiterport=5433,
         dbname=regression user=pg host=toxi port=23000 arbiterport=23001
@@ -40,7 +40,7 @@ services:
       POSTGRES_USER: 'pg'
       POSTGRES_DB: 'regression'
       NODE_ID: 3
-      CONNSTR: |
+      CONNSTRS: >-
         dbname=regression user=pg host=toxi port=31000 arbiterport=31001,
         dbname=regression user=pg host=toxi port=32000 arbiterport=32001,
         dbname=regression user=pg host=node3 arbiterport=5433

tests2/docker-entrypoint.sh

@@ -70,6 +70,8 @@ if [ "$1" = 'postgres' ]; then
 			multimaster.twopc_min_timeout = 400000
 		EOF
 
+		cat $PGDATA/postgresql.conf
+
 		pg_ctl -D "$PGDATA" -m fast -w stop
 	fi
 fi

tests2/test_regression.py

@@ -8,6 +8,7 @@ class RecoveryTest(unittest.TestCase):
     def setUpClass(self):
         subprocess.check_call(['docker-compose','up',
             '--force-recreate',
+            '--build',
             '-d'])
 
     @classmethod