Skip to content

Commit 8ffcc49

Browse files
committed
feat(empower): option targetMethods does not required any more
1 parent bc21706 commit 8ffcc49

File tree

3 files changed

+27
-63
lines changed

3 files changed

+27
-63
lines changed

Diff for: lib/default-options.js

-13
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,6 @@ module.exports = function defaultOptions () {
55
destructive: false,
66
modifyMessageOnFail: false,
77
saveContextOnFail: false,
8-
targetMethods: {
9-
oneArg: [
10-
'ok'
11-
],
12-
twoArgs: [
13-
'equal',
14-
'notEqual',
15-
'strictEqual',
16-
'notStrictEqual',
17-
'deepEqual',
18-
'notDeepEqual'
19-
]
20-
},
218
patterns: [
229
'assert(value, [message])',
2310
'assert.ok(value, [message])',

Diff for: test/buster_assertions_test.js

-6
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,7 @@
1616
var weave = function (line) {
1717
var options = {
1818
destructive: false,
19-
source: line,
2019
path: '/path/to/some_test.js',
21-
powerAssertVariableName: 'assert',
22-
targetMethods: {
23-
oneArg: ['isNull'],
24-
twoArgs: ['same']
25-
},
2620
patterns: [
2721
'assert(actual, [message])',
2822
'assert.same(actual, expected, [message])',

Diff for: test/empower_option_test.js

+27-44
Original file line numberDiff line numberDiff line change
@@ -36,23 +36,17 @@ suite('empower.defaultOptions()', function () {
3636
test('formatter: undefined', function () {
3737
assert.deepEqual(typeof this.options.formatter, 'undefined');
3838
});
39-
suite('targetMethods', function () {
40-
setup (function () {
41-
this.targetMethods = empower.defaultOptions().targetMethods;
42-
});
43-
test('oneArg', function () {
44-
assert.deepEqual(this.targetMethods.oneArg, ['ok']);
45-
});
46-
test('twoArgs', function () {
47-
assert.deepEqual(this.targetMethods.twoArgs, [
48-
'equal',
49-
'notEqual',
50-
'strictEqual',
51-
'notStrictEqual',
52-
'deepEqual',
53-
'notDeepEqual'
54-
]);
55-
});
39+
test('patterns: Array', function () {
40+
assert.deepEqual(this.options.patterns, [
41+
'assert(value, [message])',
42+
'assert.ok(value, [message])',
43+
'assert.equal(actual, expected, [message])',
44+
'assert.notEqual(actual, expected, [message])',
45+
'assert.strictEqual(actual, expected, [message])',
46+
'assert.notStrictEqual(actual, expected, [message])',
47+
'assert.deepEqual(actual, expected, [message])',
48+
'assert.notDeepEqual(actual, expected, [message])'
49+
]);
5650
});
5751
});
5852

@@ -145,15 +139,11 @@ suite('assert object empowerment', function () {
145139
setup(function () {
146140
this.options = {
147141
destructive: false,
148-
targetMethods: {
149-
oneArg: [
150-
'ok'
151-
],
152-
twoArgs: [
153-
'equal',
154-
'strictEqual'
155-
]
156-
}
142+
patterns: [
143+
'assert.ok(value, [message])',
144+
'assert.equal(actual, expected, [message])',
145+
'assert.strictEqual(actual, expected, [message])'
146+
]
157147
};
158148
this.empoweredAssert = empower(this.fakeAssertObject, fakeFormatter, this.options);
159149
});
@@ -179,15 +169,11 @@ suite('assert object empowerment', function () {
179169
setup(function () {
180170
this.options = {
181171
destructive: true,
182-
targetMethods: {
183-
oneArg: [
184-
'ok'
185-
],
186-
twoArgs: [
187-
'equal',
188-
'strictEqual'
189-
]
190-
}
172+
patterns: [
173+
'assert.ok(value, [message])',
174+
'assert.equal(actual, expected, [message])',
175+
'assert.strictEqual(actual, expected, [message])'
176+
]
191177
};
192178
this.empoweredAssert = empower(this.fakeAssertObject, fakeFormatter, this.options);
193179
});
@@ -233,15 +219,12 @@ suite('assert function empowerment', function () {
233219
setup(function () {
234220
this.options = {
235221
destructive: false,
236-
targetMethods: {
237-
oneArg: [
238-
'ok'
239-
],
240-
twoArgs: [
241-
'equal',
242-
'strictEqual'
243-
]
244-
}
222+
patterns: [
223+
'assert(value, [message])',
224+
'assert.ok(value, [message])',
225+
'assert.equal(actual, expected, [message])',
226+
'assert.strictEqual(actual, expected, [message])'
227+
]
245228
};
246229
this.empoweredAssert = empower(this.fakeAssertFunction, fakeFormatter, this.options);
247230
});

0 commit comments

Comments
 (0)