Skip to content

precice.github.io redirects to http://precice.org without TLS #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cheriimoya opened this issue Jun 7, 2023 · 3 comments
Closed

precice.github.io redirects to http://precice.org without TLS #274

cheriimoya opened this issue Jun 7, 2023 · 3 comments
Labels
technical Technical issues on the website

Comments

@cheriimoya
Copy link
Contributor

I don't really know how to change this, but maybe this is a good starting point: https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https#enforcing-https-for-your-github-pages-site

Also this is probably low prio.

@fsimonis
Copy link
Member

Hi,
The DNS resolution happens before the connection is established aka independent of the accessed port and used protocol.

If you don't specify the protocol in your browser, then it's up to the browser to pick http or https. We have seen wildly different behaviours out in the wild. Some browsers even default to the www. subdomain, which makes everything even more confusing.

So, not a priority 😉

@uekerman uekerman added the technical Technical issues on the website label Jun 15, 2023
@cheriimoya
Copy link
Contributor Author

actually i just took some time to reproduce this issue: its not really depending on the browser.

whenever you create precice.github.io, the http -> https redirect will happen.

when you insert a custom domain in the page settings of the project, the checkbox for https will be removed

image

schoenbuch: ~ $ curl http://cheriimoya.de -I
HTTP/1.1 200 OK
Connection: keep-alive
Content-Length: 17
Server: GitHub.com
Content-Type: text/html; charset=utf-8
...

and when i enable the https checkbox

schoenbuch: ~ $ curl http://cheriimoya.de -I
HTTP/1.1 301 Moved Permanently
Connection: keep-alive
Content-Length: 162
Server: GitHub.com
Content-Type: text/html
Location: https://cheriimoya.de/
...

so maybe you could double check under "settings > pages > custom domain > enforce https" since this is an issue that can be solved by github redirecting http -> https.
i am unsure why this is not the default tbh...

@uekerman
Copy link
Member

I just ticked the box. Seems to work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Technical issues on the website
Projects
None yet
Development

No branches or pull requests

3 participants