Skip to content

Commit eb5d8f3

Browse files
committed
🖊️ review code
1 parent 35f751f commit eb5d8f3

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

plotly_resampler/figure_resampler/figure_resampler_interface.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -797,16 +797,19 @@ def _construct_hf_data_dict(
797797
@staticmethod
798798
def _add_trace_to_add_traces_kwargs(kwargs: dict) -> dict:
799799
"""Convert the `add_trace` kwargs to the `add_traces` kwargs."""
800-
row = kwargs.pop("row", None)
801-
row = [row] if row is not None else None
802-
803-
cols = kwargs.pop("col", None)
804-
cols = [cols] if cols is not None else None
805-
806-
secondary_ys = kwargs.pop("secondary_y", None)
807-
secondary_ys = [secondary_ys] if secondary_ys is not None else None
800+
# The keywords that need to be converted to a list
801+
convert_keywords = ["row", "col", "secondary_y"]
802+
803+
updated_kwargs = {} # The updated kwargs (from `add_trace` to `add_traces`)
804+
for keyword in convert_keywords:
805+
value = kwargs.pop(keyword, None)
806+
if value is not None:
807+
updated_kwargs[f"{keyword}s"] = [value]
808+
else:
809+
updated_kwargs[f"{keyword}s"] = None
810+
811+
return {**kwargs, **updated_kwargs}
808812

809-
return {**kwargs, "rows": row, "cols": cols, "secondary_ys": secondary_ys}
810813

811814
def add_trace(
812815
self,

0 commit comments

Comments
 (0)