Skip to content

Do we still need interleave_gaps? #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonasvdd opened this issue Apr 24, 2023 · 1 comment
Closed

Do we still need interleave_gaps? #202

jonasvdd opened this issue Apr 24, 2023 · 1 comment

Comments

@jonasvdd
Copy link
Member

jonasvdd commented Apr 24, 2023 •
edited
Loading

PR #199 decoupled the gap handlers from the downsample instances. As such, we do not need the interleave_gaps argument in:

  • the FigureResamplerInterface add trace method
  • the AbstractDownsampler Class
  • the tests
@jonasvdd jonasvdd mentioned this issue Apr 28, 2023
Merged
@jvdd
Copy link
Member

jvdd commented Apr 30, 2023

Closing since this is tackled in #204

@jvdd jvdd closed this as completed Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvdd @jonasvdd