Skip to content

Missing points #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AhmedThahir opened this issue Jul 10, 2022 · 7 comments
Closed

Missing points #99

AhmedThahir opened this issue Jul 10, 2022 · 7 comments
Assignees
Labels
discussion open discussion about some functionality documentation Improvements or additions to documentation

Comments

@AhmedThahir
Copy link

AhmedThahir commented Jul 10, 2022

Why are points missing?
From the watching the gif linked from your research paper, I thought that it would resample once again when I zoom in.

Code for the data

from plotly_resampler import FigureResampler
x = np.arange(10_000)
noisy_sin = (3 + np.sin(x / 200) + np.random.randn(len(x)) / 10) * x / 1_000

Before Zooming

Not Resampled

image

Resampled

image

After Zooming

Not Resampled

image

Resampled

image

@jonasvdd
Copy link
Member

@AhmedThahir As you've closed this issue I suppose you found in the readme/docs that the "show" method returns a static figure whereas the "show_dash" method (for the FigureResampler) enables this interactive resampling

@AhmedThahir
Copy link
Author

What's the difference between

  • using show_dash with FigureResampler
  • using show with FigureWidgetResampler

@AhmedThahir AhmedThahir reopened this Jul 11, 2022
@jonasvdd
Copy link
Member

Hi @AhmedThahir,

I agree this is somewhat confusing, I think this can be best summarized with:

  • show always returns a static figure view i.e., no dynamic aggregation will be performed
  • To have dynamic aggregation:
    • with FigureResampler, you need to call show_dash -> which spawns a dash-web app, and the dynamic aggregation is realized with dash callback
    • with FigureWidgetResampler, you need to use IPython.display, which uses widget-events to realize dynamic aggregation.

Did you find our docs confusing? If so, where would you like to get more of this information? Together we can further improve this toolkit 😄

@jonasvdd jonasvdd self-assigned this Jul 11, 2022
@jonasvdd jonasvdd added documentation Improvements or additions to documentation discussion open discussion about some functionality labels Jul 11, 2022
@AhmedThahir
Copy link
Author

Ah got it now.

Regarding the documentation, I believe it's pretty good. Only that this particular concept that you just clarified wasn't very clear.

If you could add this to an FAQ section or something, it'd be great.

@jvdd
Copy link
Member

jvdd commented Jul 11, 2022

Great suggestion about the FAQ, I'm very keen on adding this. What do you think @jonasvdd?

@jonasvdd
Copy link
Member

Agree, we can add an FAQ tab to the docs, but would create a separate PR for that!

@jvdd jvdd mentioned this issue Jul 17, 2022
13 tasks
@jonasvdd
Copy link
Member

@AhmedThahir,

Now there is an FAQ section in our docs. (https://predict-idlab.github.io/plotly-resampler/FAQ.html
This issue is documented there aswell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion open discussion about some functionality documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants