Skip to content

Commit 71621e3

Browse files
committed
fix: remove comments
1 parent 6e5fe09 commit 71621e3

File tree

2 files changed

+1
-59
lines changed

2 files changed

+1
-59
lines changed

packages/superset-ui-preset-chart-xy/src/BoxPlot/Encoder.ts

Lines changed: 1 addition & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -17,62 +17,10 @@ export const boxPlotEncoderFactory = createEncoderFactory<BoxPlotEncodingConfig>
1717
defaultEncoding: {
1818
x: { field: 'x', type: 'nominal' },
1919
y: { field: 'y', type: 'quantitative' },
20-
color: { value: 'black' },
20+
color: { value: '#222' },
2121
},
2222
});
2323

2424
export type BoxPlotEncoding = DeriveEncoding<BoxPlotEncodingConfig>;
2525

2626
export type BoxPlotEncoder = Encoder<BoxPlotEncodingConfig>;
27-
28-
// import { Value } from 'vega-lite/build/src/channeldef';
29-
// import { ChannelTypeToDefMap } from '../encodeable/types/Channel';
30-
// import { ExtractChannelOutput } from '../encodeable/types/ChannelDef';
31-
// import createEncoderClass from '../encodeable/createEncoderClass';
32-
33-
// /**
34-
// * Define channel types
35-
// */
36-
// const channelTypes = {
37-
// color: 'Color',
38-
// x: 'XBand',
39-
// y: 'YBand',
40-
// } as const;
41-
42-
// export type ChannelTypes = typeof channelTypes;
43-
44-
// /**
45-
// * TEMPLATE:
46-
// * Helper for defining encoding
47-
// */
48-
// type CreateChannelDef<
49-
// ChannelName extends keyof ChannelTypes,
50-
// Output extends Value
51-
// > = ChannelTypeToDefMap<Output>[ChannelTypes[ChannelName]];
52-
53-
// /**
54-
// * Encoding definition
55-
// */
56-
// export type Encoding = {
57-
// color: CreateChannelDef<'color', string>;
58-
// x: CreateChannelDef<'x', number | null>;
59-
// y: CreateChannelDef<'y', number | null>;
60-
// };
61-
62-
// /**
63-
// * TEMPLATE:
64-
// * Can use this to get returned type of a Channel
65-
// * example usage: ChannelOutput<'x'>
66-
// */
67-
// export type ChannelOutput<ChannelName extends keyof Encoding> = ExtractChannelOutput<
68-
// Encoding[ChannelName]
69-
// >;
70-
71-
// export default class Encoder extends createEncoderClass<ChannelTypes, Encoding>({
72-
// channelTypes,
73-
// defaultEncoding: {
74-
// color: { value: '#222' },
75-
// x: { field: 'x', type: 'nominal' },
76-
// y: { field: 'y', type: 'quantitative' },
77-
// },
78-
// }) {}

packages/superset-ui-preset-chart-xy/src/components/legend2/types.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,6 @@ import { CSSProperties } from 'react';
22
import { EncodingConfig } from 'encodable/lib/types/Encoding';
33
import { LegendGroupInformation, LegendItemInformation } from 'encodable/lib/types/Legend';
44

5-
// export type LegendItemInfo<Config extends EncodingConfig> = {
6-
// field: string;
7-
// value: ChannelInput;
8-
// encodedValues: Partial<Record<keyof Encoding, Value | undefined>>;
9-
// };
10-
115
export type LegendItemMarkRendererType<Config extends EncodingConfig> = React.ComponentType<{
126
group: LegendGroupInformation<Config>;
137
item: LegendItemInformation<Config>;

0 commit comments

Comments
 (0)