Skip to content

Commit 345868a

Browse files
Addinng more properties to playground story for token & skeletonText (#6096)
Co-authored-by: Marie Lucca <[email protected]> Co-authored-by: Marie Lucca <[email protected]>
1 parent 3beba5b commit 345868a

File tree

4 files changed

+63
-7
lines changed

4 files changed

+63
-7
lines changed

packages/react/src/Token/Token.features.stories.tsx

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export const TokenWithLeadingVisual = () => {
4242
return <Token text="token" leadingVisual={GitBranchIcon} />
4343
}
4444

45-
export const TokenWithOnRemoveFn = () => {
45+
export const TokenWithOnRemoveFn = ({...args}) => {
4646
return (
4747
<Box
4848
display="flex"
@@ -51,19 +51,31 @@ export const TokenWithOnRemoveFn = () => {
5151
gap: get('space.2'),
5252
}}
5353
>
54-
<Token text="token" onRemove={action('remove me')} />
54+
<Token text="token" onRemove={action('remove me')} {...args} />
5555
<Token
5656
as="a"
5757
href="/?path=/story/components-token-features--issue-label-token-custom-colors"
5858
onRemove={action('remove me')}
5959
text="Link"
60+
{...args}
6061
/>
61-
<Token as="button" onClick={action('clicked')} onRemove={action('remove me')} text="Button" />
62+
<Token as="button" onClick={action('clicked')} onRemove={action('remove me')} text="Button" {...args} />
6263
</Box>
6364
)
6465
}
6566

6667
TokenWithOnRemoveFn.storyName = 'Token with onRemove fn'
68+
TokenWithOnRemoveFn.args = {
69+
size: 'medium',
70+
}
71+
TokenWithOnRemoveFn.argTypes = {
72+
size: {
73+
control: {
74+
type: 'radio',
75+
},
76+
options: ['small', 'medium', 'large', 'xlarge'],
77+
},
78+
}
6779

6880
export const DefaultIssueLabelToken = () => {
6981
return <IssueLabelToken text="good first issue" />
@@ -115,6 +127,7 @@ export const IssueLabelTokenWithOnRemoveFn = () => {
115127
IssueLabelTokenWithOnRemoveFn.storyName = 'IssueLabelToken with onRemove fn'
116128

117129
export const SmallToken = () => <Token text="token" size="small" />
130+
export const MediumlToken = () => <Token text="token" size="medium" />
118131
export const LargeToken = () => <Token text="token" size="xlarge" />
119132
export const XLargeToken = () => <Token text="token" size="xlarge" />
120133

Lines changed: 41 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import type {Meta, StoryFn} from '@storybook/react'
2+
import {action} from '@storybook/addon-actions'
23
import Token from './Token'
4+
import {GitBranchIcon} from '@primer/octicons-react'
35

46
export default {
57
title: 'Components/Token',
@@ -8,12 +10,24 @@ export default {
810

911
export const Default = () => <Token text="token" />
1012

11-
export const Playground: StoryFn<typeof Token> = args => {
12-
return <Token {...args} />
13+
export const Playground: StoryFn<typeof Token> = ({onRemove, onClick, leadingVisual, ...args}) => {
14+
return (
15+
<Token
16+
{...args}
17+
onRemove={onRemove ? action('onRemove') : undefined}
18+
onClick={onClick ? action('onClick') : undefined}
19+
leadingVisual={leadingVisual ? GitBranchIcon : undefined}
20+
/>
21+
)
1322
}
1423
Playground.args = {
1524
text: 'Token',
1625
size: 'medium',
26+
isSelected: false,
27+
leadingVisual: undefined,
28+
hideRemoveButton: false,
29+
onRemove: undefined,
30+
onClick: undefined,
1731
}
1832
Playground.argTypes = {
1933
size: {
@@ -22,4 +36,29 @@ Playground.argTypes = {
2236
},
2337
options: ['small', 'medium', 'large', 'xlarge'],
2438
},
39+
isSelected: {
40+
control: {
41+
type: 'boolean',
42+
},
43+
},
44+
leadingVisual: {
45+
control: {
46+
type: 'boolean',
47+
},
48+
},
49+
hideRemoveButton: {
50+
control: {
51+
type: 'boolean',
52+
},
53+
},
54+
onRemove: {
55+
control: {
56+
type: 'boolean',
57+
},
58+
},
59+
onClick: {
60+
control: {
61+
type: 'boolean',
62+
},
63+
},
2564
}

packages/react/src/experimental/Skeleton/SkeletonAvatar.stories.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const Playground: StoryFn<Args> = args => {
2424

2525
Playground.args = {
2626
size: DEFAULT_AVATAR_SIZE,
27+
square: false,
2728
}
2829

2930
Playground.argTypes = {

packages/react/src/experimental/Skeleton/SkeletonText.stories.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,15 @@ Playground.args = {
1818

1919
Playground.argTypes = {
2020
lines: {
21-
type: 'number',
21+
control: {type: 'range', min: 1, max: 10, step: 1},
2222
},
2323
maxWidth: {
2424
type: 'string',
2525
},
2626
size: {
27-
type: 'string',
27+
control: {
28+
type: 'select',
29+
},
30+
options: ['bodySmall', 'bodyMedium', 'bodyLarge', 'titleSmall', 'titleMedium', 'titleLarge', 'display', 'subtitle'],
2831
},
2932
}

0 commit comments

Comments
 (0)