Preserve context in snapshotDeletionListeners (elastic#84089)

DaveCTurner · probakowski · commit 1fa44270fe7d · 2022-02-23T22:41:06.000+01:00
Closes elastic#84036
diff --git a/docs/changelog/84089.yaml b/docs/changelog/84089.yaml
@@ -0,0 +1,6 @@
+pr: 84089
+summary: Preserve context in `snapshotDeletionListeners`
+area: Snapshot/Restore
+type: bug
+issues:
+ - 84036
diff --git a/server/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java b/server/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java
@@ -2289,7 +2289,8 @@ private static boolean isWritingToRepository(SnapshotsInProgress.Entry entry) {
     }
 
     private void addDeleteListener(String deleteUUID, ActionListener<Void> listener) {
-        snapshotDeletionListeners.computeIfAbsent(deleteUUID, k -> new CopyOnWriteArrayList<>()).add(listener);
+        snapshotDeletionListeners.computeIfAbsent(deleteUUID, k -> new CopyOnWriteArrayList<>())
+            .add(ContextPreservingActionListener.wrapPreservingContext(listener, threadPool.getThreadContext()));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -2289,7 +2289,8 @@ private static boolean isWritingToRepository(SnapshotsInProgress.Entry entry) {`
`2289`	`2289`	`}`
`2290`	`2290`
`2291`	`2291`	`private void addDeleteListener(String deleteUUID, ActionListener<Void> listener) {`
`2292`		`- snapshotDeletionListeners.computeIfAbsent(deleteUUID, k -> new CopyOnWriteArrayList<>()).add(listener);`
	`2292`	`+ snapshotDeletionListeners.computeIfAbsent(deleteUUID, k -> new CopyOnWriteArrayList<>())`
	`2293`	`+ .add(ContextPreservingActionListener.wrapPreservingContext(listener, threadPool.getThreadContext()));`
`2293`	`2294`	`}`
`2294`	`2295`
`2295`	`2296`	`/**`