Replace User form buttons with shared Button component

Author: andrewn

Diff for: client/modules/User/components/GithubButton.jsx

@@ -1,6 +1,8 @@
 import PropTypes from 'prop-types';
 import React from 'react';
+
 import { domOnlyProps } from '../../../utils/reduxFormUtils';
+import Button from '../../../common/Button';
 
 function NewPasswordForm(props) {
   const {
@@ -34,7 +36,7 @@ function NewPasswordForm(props) {
           <span className="form-error">{confirmPassword.error}</span>
         }
       </p>
-      <input type="submit" disabled={submitting || invalid || pristine} value="Set New Password" aria-label="sign up" />
+      <Button type="submit" disabled={submitting || invalid || pristine} label="sign up">Set New Password</Button>
     </form>
   );
 }

Diff for: client/modules/User/components/GoogleButton.jsx

@@ -1,6 +1,8 @@
 import PropTypes from 'prop-types';
 import React from 'react';
+
 import { domOnlyProps } from '../../../utils/reduxFormUtils';
+import Button from '../../../common/Button';
 
 function ResetPasswordForm(props) {
   const {
@@ -19,12 +21,12 @@ function ResetPasswordForm(props) {
         />
         {email.touched && email.error && <span className="form-error">{email.error}</span>}
       </p>
-      <input
+      <Button
         type="submit"
         disabled={submitting || invalid || pristine || props.user.resetPasswordInitiate}
-        value="Send Password Reset Email"
-        aria-label="Send email to reset password"
-      />
+        label="Send email to reset password"
+      >Send Password Reset Email
+      </Button>
     </form>
   );
 }

Diff for: client/modules/User/components/NewPasswordForm.jsx

@@ -1,6 +1,8 @@
 import PropTypes from 'prop-types';
 import React from 'react';
+
 import { domOnlyProps } from '../../../utils/reduxFormUtils';
+import Button from '../../../common/Button';
 
 function SignupForm(props) {
   const {
@@ -58,7 +60,12 @@ function SignupForm(props) {
           <span className="form-error">{confirmPassword.error}</span>
         }
       </p>
-      <input type="submit" disabled={submitting || invalid || pristine} value="Sign Up" aria-label="sign up" />
+      <Button
+        type="submit"
+        disabled={submitting || invalid || pristine}
+        label="sign up"
+      >Sign Up
+      </Button>
     </form>
   );
 }

Diff for: client/modules/User/components/ResetPasswordForm.jsx

@@ -0,0 +1,55 @@
+import PropTypes from 'prop-types';
+import React from 'react';
+import styled from 'styled-components';
+
+import { remSize, prop } from '../../../theme';
+
+import Button from '../../../common/Button';
+import Icon from '../../../common/Icon';
+
+const authUrls = {
+  github: '/auth-github',
+  google: '/auth/google/'
+};
+
+const labels = {
+  github: 'Login with GitHub',
+  google: 'Login with Google'
+};
+
+const services = {
+  github: 'github',
+  google: 'google'
+};
+
+const StyledButton = styled(Button)`
+  width: ${remSize(300)};
+
+  > * + * {
+    margin-left: ${remSize(10)};
+  }
+`;
+
+const StyledIcon = styled(Icon)`
+  width: ${remSize(32)};
+  height: ${remSize(32)};
+`;
+
+function SocialAuthButton({ service }) {
+  return (
+    <StyledButton
+      href={authUrls[service]}
+    >
+      <StyledIcon name={Icon.names[service]} />
+      <span>{labels[service]}</span>
+    </StyledButton>
+  );
+}
+
+SocialAuthButton.services = services;
+
+SocialAuthButton.propTypes = {
+  service: PropTypes.oneOf(['github', 'google']).isRequired
+};
+
+export default SocialAuthButton;

Diff for: client/modules/User/components/SignupForm.jsx

@@ -0,0 +1,16 @@
+import React from 'react';
+
+import SocialAuthButton from './SocialAuthButton';
+
+export default {
+  title: 'User/components/SocialAuthButton',
+  component: SocialAuthButton
+};
+
+export const Github = () => (
+  <SocialAuthButton service={SocialAuthButton.services.github}>Log in with Github</SocialAuthButton>
+);
+
+export const Google = () => (
+  <SocialAuthButton service={SocialAuthButton.services.google}>Sign up with Google</SocialAuthButton>
+);

Diff for: client/modules/User/components/SocialAuthButton.jsx

@@ -8,8 +8,7 @@ import { Helmet } from 'react-helmet';
 import { updateSettings, initiateVerification, createApiKey, removeApiKey } from '../actions';
 import AccountForm from '../components/AccountForm';
 import { validateSettings } from '../../../utils/reduxFormUtils';
-import GithubButton from '../components/GithubButton';
-import GoogleButton from '../components/GoogleButton';
+import SocialAuthButton from '../components/SocialAuthButton';
 import APIKeyForm from '../components/APIKeyForm';
 import Nav from '../../../components/Nav';
 
@@ -24,8 +23,8 @@ function SocialLoginPanel(props) {
       <p className="account__social-text">
         Use your GitHub or Google account to log into the p5.js Web Editor.
       </p>
-      <GithubButton buttonText="Login with GitHub" />
-      <GoogleButton buttonText="Login with Google" />
+      <SocialAuthButton service={SocialAuthButton.services.github} />
+      <SocialAuthButton service={SocialAuthButton.services.google} />
     </React.Fragment>
   );
 }

Diff for: client/modules/User/components/SocialAuthButton.stories.jsx

@@ -2,8 +2,11 @@ import PropTypes from 'prop-types';
 import React from 'react';
 import { connect } from 'react-redux';
 import { bindActionCreators } from 'redux';
-import { browserHistory, Link } from 'react-router';
+import { browserHistory } from 'react-router';
 import { updateSettings, initiateVerification, createApiKey, removeApiKey } from '../actions';
+
+import Button from '../../../common/Button';
+
 import Nav from '../../../components/Nav';
 import Overlay from '../../App/components/Overlay';
 
@@ -79,16 +82,16 @@ class DashboardView extends React.Component {
       case TabKey.collections:
         return this.isOwner() && (
           <React.Fragment>
-            <Link className="dashboard__action-button" to={`/${username}/collections/create`}>
+            <Button to={`/${username}/collections/create`}>
               Create collection
-            </Link>
+            </Button>
             <CollectionSearchbar />
           </React.Fragment>);
       case TabKey.sketches:
       default:
         return (
           <React.Fragment>
-            {this.isOwner() && <Link className="dashboard__action-button" to="/">New sketch</Link>}
+            {this.isOwner() && <Button to="/">New sketch</Button>}
             <SketchSearchbar />
           </React.Fragment>
         );

Diff for: client/modules/User/pages/AccountView.jsx

@@ -6,8 +6,7 @@ import { Helmet } from 'react-helmet';
 import { validateAndLoginUser } from '../actions';
 import LoginForm from '../components/LoginForm';
 import { validateLogin } from '../../../utils/reduxFormUtils';
-import GithubButton from '../components/GithubButton';
-import GoogleButton from '../components/GoogleButton';
+import SocialAuthButton from '../components/SocialAuthButton';
 import Nav from '../../../components/Nav';
 
 class LoginView extends React.Component {
@@ -41,8 +40,10 @@ class LoginView extends React.Component {
             <h2 className="form-container__title">Log In</h2>
             <LoginForm {...this.props} />
             <h2 className="form-container__divider">Or</h2>
-            <GithubButton buttonText="Login with Github" />
-            <GoogleButton buttonText="Login with Google" />
+            <div className="form-container__stack">
+              <SocialAuthButton service={SocialAuthButton.services.github} />
+              <SocialAuthButton service={SocialAuthButton.services.google} />
+            </div>
             <p className="form__navigation-options">
               Don&apos;t have an account?&nbsp;
               <Link className="form__signup-button" to="/signup">Sign Up</Link>

Diff for: client/modules/User/pages/DashboardView.jsx

@@ -83,8 +83,3 @@
 .dashboard-header__actions > *:not(:first-child) {
   margin-left: #{15 / $base-font-size}rem;
 }
-
-.dashboard__action-button {
-  flex-grow: 0;
-  @extend %button;
-}

Diff for: client/modules/User/pages/LoginView.jsx

@@ -57,3 +57,7 @@
 .form-container__exit-button {
 	@include icon();
 }
+
+.form-container__stack > * + * {
+	margin-top: #{10 / $base-font-size}rem;
+}

Diff for: client/styles/components/_dashboard-header.scss

@@ -9,6 +9,10 @@
   }
 }
 
+.form > * + * {
+  margin-top: #{12 / $base-font-size}rem;
+}
+
 .form--inline {
   display: flex;
   align-items: center;
@@ -78,20 +82,25 @@
 }
 
 .form [type="submit"] {
-  @extend %button;
-  padding: #{8 / $base-font-size}rem #{25 / $base-font-size}rem;
-  margin: #{39 / $base-font-size}rem 0 #{24 / $base-font-size}rem 0;
+  margin-left: auto;
+  margin-right: auto;
 }
 
-.form [type="submit"][disabled] {
-  cursor: not-allowed;
-}
+// .form [type="submit"] {
+//   @extend %button;
+//   padding: #{8 / $base-font-size}rem #{25 / $base-font-size}rem;
+//   margin: #{39 / $base-font-size}rem 0 #{24 / $base-font-size}rem 0;
+// }
 
-.form--inline [type="submit"] {
-  margin: 0 0 0 #{24 / $base-font-size}rem;
-}
+// .form [type="submit"][disabled] {
+//   cursor: not-allowed;
+// }
 
-.form [type="submit"][disabled],
-.form--inline [type="submit"][disabled] {
-  cursor: not-allowed;
-}
+// .form--inline [type="submit"] {
+//   margin: 0 0 0 #{24 / $base-font-size}rem;
+// }
+
+// .form [type="submit"][disabled],
+// .form--inline [type="submit"][disabled] {
+//   cursor: not-allowed;
+// }

Diff for: client/styles/components/_form-container.scss

@@ -31,7 +31,6 @@
 @import 'components/resizer';
 @import 'components/overlay';
 @import 'components/about';
-@import 'components/github-button';
 @import 'components/forms';
 @import 'components/toast';
 @import 'components/timer';