Skip to content

Wrong status code returned for sketch/file that does not exist #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thegitone23 opened this issue Feb 17, 2020 · 2 comments · Fixed by #1265
Closed

Wrong status code returned for sketch/file that does not exist #1264

thegitone23 opened this issue Feb 17, 2020 · 2 comments · Fixed by #1265

Comments

@thegitone23
Copy link
Contributor

thegitone23 commented Feb 17, 2020 •
edited by catarak
Loading

Nature of issue?

  • Found a bug

Details about the bug:

  • Web browser and version: Firefox
  • Operating System: Linux
  • Steps to reproduce this bug:
    Go to https://editor.p5js.org/sketches/any_id/assets/any_file and 502 is returned.
    The problem is caused by the fact that the function getFileContent which is supposed to handle this route isn't verifying whether the returned object from database is null or not and it's also not checking for undefined asset name.

Because the sketch/file does not exist, a 404 error should be returned.
@welcome
Copy link

welcome bot commented Feb 17, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@thegitone23
Copy link
Contributor Author

thegitone23 commented Feb 17, 2020 •
edited
Loading

I am doing a pr to fix this issue
#1265

@thegitone23 thegitone23 changed the title Method getFileContent doesn't handle invalid project id Method handeling route to get assets corresponding to a project isn't handeling invalid project id or empty asset parameter Feb 18, 2020
@thegitone23 thegitone23 mentioned this issue Feb 26, 2020
Merged
3 tasks
@catarak catarak changed the title Method handeling route to get assets corresponding to a project isn't handeling invalid project id or empty asset parameter Wrong status code returned for sketch/file that does not exist Mar 30, 2020
@ceciliahollins ceciliahollins mentioned this issue Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added safegaurd against invalid project id and undefined file path thegitone23/p5.js-web-editor
1 participant
@thegitone23