Skip to content

Length of File Name Cause \n (line break) display in Preview #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeyaoli opened this issue May 2, 2020 · 4 comments · Fixed by #1448
Closed

Length of File Name Cause \n (line break) display in Preview #1413

zeyaoli opened this issue May 2, 2020 · 4 comments · Fixed by #1448

Comments

@zeyaoli
Copy link

zeyaoli commented May 2, 2020

Nature of issue?

  • Found a bug

Details about the bug:

If a user creates a new js file (or multiple files) naming with only two letters, it returns "\n" (line break) on the preview. See example: https://editor.p5js.org/zeyaoli/sketches/T8PHsajuq I created gu.js, and du.js, which returns two "\n". If I took one file off, it showed one "\n".

  • Web browser and version: Chrome Version 81.0.4044.122 (Official Build) (64-bit)
  • Operating System: MacOS Ver 10.15.2
  • Steps to reproduce this bug:

In the HTML page, it renders code like under;

" \n      "
<script data-tag="\"@fs-du"],[86,"du.js\">...</script>
" \n     "

If I changed the file name from gu.js to gu-file.js, then the line break is gone.

Screen Shot 2020-05-02 at 5 27 51 PM

Screen Shot 2020-05-02 at 5 34 21 PM

@welcome
Copy link

welcome bot commented May 2, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented May 6, 2020

Thank you!! This is a very strange bug 🥵

@SebasMag
Copy link

SebasMag commented Jun 4, 2020

Hi ! I think this is a good first issue for me , can i go ahead fixing this ?

@SebasMag
Copy link

SebasMag commented Jun 4, 2020

I'm working on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants